aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzeripath2021-08-21 03:17:07 +0100
committerGitHub2021-08-20 22:17:07 -0400
commitbc1fefce873384cdde2fb15f76fe3f375d8129db (patch)
tree13b6af1e9b80846077a9efb380839d554e1074c5
parentbb054fdfa132d589cfda894427ce0c2dc8c652ae (diff)
Recreate Tables should Recreate indexes on MySQL (#16718) (#16740)
Backport #16718 The MySQL indexes are not being renamed at the same time as RENAME table despite the CASCADE. Therefore it is probably better to just recreate the indexes instead. Signed-off-by: Andrew Thornton <art27@cantab.net>
-rw-r--r--models/migrations/migrations.go15
1 files changed, 15 insertions, 0 deletions
diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go
index 2c85ebdfd..ab1a41d4c 100644
--- a/models/migrations/migrations.go
+++ b/models/migrations/migrations.go
@@ -565,11 +565,26 @@ func recreateTable(sess *xorm.Session, bean interface{}) error {
return err
}
+ if err := sess.Table(tempTableName).DropIndexes(bean); err != nil {
+ log.Error("Unable to drop indexes on temporary table %s. Error: %v", tempTableName, err)
+ return err
+ }
+
// SQLite and MySQL will move all the constraints from the temporary table to the new table
if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` RENAME TO `%s`", tempTableName, tableName)); err != nil {
log.Error("Unable to rename %s to %s. Error: %v", tempTableName, tableName, err)
return err
}
+
+ if err := sess.Table(tableName).CreateIndexes(bean); err != nil {
+ log.Error("Unable to recreate indexes on table %s. Error: %v", tableName, err)
+ return err
+ }
+
+ if err := sess.Table(tableName).CreateUniques(bean); err != nil {
+ log.Error("Unable to recreate uniques on table %s. Error: %v", tableName, err)
+ return err
+ }
case setting.Database.UsePostgreSQL:
var originalSequences []string
type sequenceData struct {