Implement an ugly hack for gob Marshal/Unmarshal the LangRefValue type

Changes

2 changed files (+117/-0)

• natural_language_values.go
  • @@ -256,6 +256,38 @@ func (l LangRefValue) MarshalText() ([]byte, error) {
    return buf.Bytes(), nil } + type kv struct { + K []byte + V []byte + } + + func (l LangRefValue) GobEncode() ([]byte, error) { + b := new(bytes.Buffer) + gg := gob.NewEncoder(b) + mm := kv{ + K: []byte(l.Ref), + V: []byte(l.Value), + } + if err := gg.Encode(mm); err != nil { + return nil, err + } + return b.Bytes(), nil + } + + func (l *LangRefValue) GobDecode(data []byte) error { + if len(data) == 0 { + // NOTE(marius): this behaviour diverges from vanilla gob package + return nil + } + mm := kv{} + if err := gob.NewDecoder(bytes.NewReader(data)).Decode(&mm); err != nil { + return err + } + l.Ref = LangRef(mm.K) + l.Value = mm.V + return nil + } + // UnmarshalJSON decodes an incoming JSON document into the receiver object. func (l *LangRef) UnmarshalJSON(data []byte) error { return l.UnmarshalText(data)
• natural_language_values_test.go
  • @@ -688,3 +688,88 @@ func TestLangRef_GobEncode(t *testing.T) {
    }) } } + + func TestLangRefValue_GobEncode(t *testing.T) { + type fields struct { + Ref LangRef + Value Content + } + tests := []struct { + name string + fields fields + want []byte + wantErr bool + }{ + { + name: "empty", + fields: fields{}, + want: gobValue(kv{}), + wantErr: false, + }, + { + name: "some values", + fields: fields{ + Ref: "ana", + Value: Content("are mere"), + }, + want: gobValue(kv{K: []byte("ana"), V: []byte("are mere")}), + wantErr: false, + }, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + l := LangRefValue{ + Ref: tt.fields.Ref, + Value: tt.fields.Value, + } + got, err := l.GobEncode() + if (err != nil) != tt.wantErr { + t.Errorf("GobEncode() error = %v, wantErr %v", err, tt.wantErr) + return + } + if !reflect.DeepEqual(got, tt.want) { + t.Errorf("GobEncode() got = %v, want %v", got, tt.want) + } + }) + } + } + + func TestLangRefValue_GobDecode(t *testing.T) { + type fields struct { + Ref LangRef + Value Content + } + tests := []struct { + name string + fields fields + data []byte + wantErr bool + }{ + { + name: "empty", + fields: fields{}, + data: gobValue(kv{}), + wantErr: false, + }, + { + name: "some values", + fields: fields{ + Ref: "ana", + Value: Content("are mere"), + }, + data: gobValue(kv{K: []byte("ana"), V: []byte("are mere")}), + wantErr: false, + }, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + l := &LangRefValue{ + Ref: tt.fields.Ref, + Value: tt.fields.Value, + } + if err := l.GobDecode(tt.data); (err != nil) != tt.wantErr { + t.Errorf("GobDecode() error = %v, wantErr %v", err, tt.wantErr) + } + }) + } + }