Finish the implementation of gob encode/decode for Item interface

Changes

2 changed files (+24/-16)

• decoding_gob.go
  • @@ -4,7 +4,6 @@ import (
    "bytes" "encoding/gob" "errors" - "fmt" "time" )
  • @@ -457,39 +456,39 @@ func gobDecodeItem(data []byte) (Item, error) {
    }) case CollectionType: err = OnCollection(it, func(c *Collection) error { - return fmt.Errorf("TODO: Implement decode of %T", c) + return unmapCollectionProperties(mm, c) }) case OrderedCollectionType: err = OnOrderedCollection(it, func(c *OrderedCollection) error { - return fmt.Errorf("TODO: Implement decode of %T", c) + return unmapOrderedCollectionProperties(mm, c) }) case CollectionPageType: err = OnCollectionPage(it, func(p *CollectionPage) error { - return fmt.Errorf("TODO: Implement decode of %T", p) + return unmapCollectionPageProperties(mm, p) }) case OrderedCollectionPageType: err = OnOrderedCollectionPage(it, func(p *OrderedCollectionPage) error { - return fmt.Errorf("TODO: Implement decode of %T", p) + return unmapOrderedCollectionPageProperties(mm, p) }) case PlaceType: err = OnPlace(it, func(p *Place) error { - return fmt.Errorf("TODO: Implement decode of %T", p) + return unmapPlaceProperties(mm, p) }) case ProfileType: err = OnProfile(it, func(p *Profile) error { - return fmt.Errorf("TODO: Implement decode of %T", p) + return unmapProfileProperties(mm, p) }) case RelationshipType: err = OnRelationship(it, func(r *Relationship) error { - return fmt.Errorf("TODO: Implement decode of %T", r) + return unmapRelationshipProperties(mm, r) }) case TombstoneType: err = OnTombstone(it, func(t *Tombstone) error { - return fmt.Errorf("TODO: Implement decode of %T", t) + return unmapTombstoneProperties(mm, t) }) case QuestionType: err = OnQuestion(it, func(q *Question) error { - return fmt.Errorf("TODO: Implement decode of %T", q) + return unmapQuestionProperties(mm, q) }) } return it, err
• encoding_gob.go
  • @@ -3,7 +3,6 @@ package activitypub
    import ( "bytes" "encoding/gob" - "fmt" ) // TODO(marius): when migrating to go1.18, use a numeric constraint for this
  • @@ -151,23 +150,33 @@ func gobEncodeItem(it Item) ([]byte, error) {
    }) case PlaceType: err = OnPlace(it, func(p *Place) error { - return fmt.Errorf("TODO: Implement encode of %T", p) + bytes, err := p.GobEncode() + b.Write(bytes) + return err }) case ProfileType: err = OnProfile(it, func(p *Profile) error { - return fmt.Errorf("TODO: Implement encode of %T", p) + bytes, err := p.GobEncode() + b.Write(bytes) + return err }) case RelationshipType: err = OnRelationship(it, func(r *Relationship) error { - return fmt.Errorf("TODO: Implement encode of %T", r) + bytes, err := r.GobEncode() + b.Write(bytes) + return err }) case TombstoneType: err = OnTombstone(it, func(t *Tombstone) error { - return fmt.Errorf("TODO: Implement encode of %T", t) + bytes, err := t.GobEncode() + b.Write(bytes) + return err }) case QuestionType: err = OnQuestion(it, func(q *Question) error { - return fmt.Errorf("TODO: Implement encode of %T", q) + bytes, err := q.GobEncode() + b.Write(bytes) + return err }) } return b.Bytes(), err