diff options
| author | Lunny Xiao | 2020-02-14 19:53:36 +0800 |
|---|---|---|
| committer | GitHub | 2020-02-14 13:53:36 +0200 |
| commit | e786f098d50494cb3c8ecb716572f1a155616a00 (patch) | |
| tree | 9af3f91320287241419a69b6c98fd160492ef8fa | |
| parent | 22dec1cea6ad9a0a22b62de6bbc097cf3f2e1711 (diff) | |
Fix reply on code review (#10261)
* Fix branch page pull request title and link error (#10092)
* Fix branch page pull request title and link error
* Fix ui
* Fix reply on code review (#10227)
Co-authored-by: zeripath <art27@cantab.net>
* Revert unrelated change
* Fix lint
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
| -rw-r--r-- | public/js/index.js | 10 | ||||
| -rw-r--r-- | templates/repo/diff/comment_form.tmpl | 3 |
2 files changed, 11 insertions, 2 deletions
diff --git a/public/js/index.js b/public/js/index.js index c04af8cbe..46ff00d01 100644 --- a/public/js/index.js +++ b/public/js/index.js @@ -1,6 +1,6 @@ /* globals wipPrefixes, issuesTribute, emojiTribute */ /* exported timeAddManual, toggleStopwatch, cancelStopwatch, initHeatmap */ -/* exported toggleDeadlineForm, setDeadline, deleteDependencyModal, cancelCodeComment, onOAuthLoginClick */ +/* exported toggleDeadlineForm, setDeadline, deleteDependencyModal, submitReply, cancelCodeComment, onOAuthLoginClick */ 'use strict'; function htmlEncode(text) { @@ -3171,6 +3171,14 @@ function cancelCodeComment(btn) { form.closest('.comment-code-cloud').remove() } } + +function submitReply(btn) { + const form = $(btn).closest('form'); + if (form.length > 0 && form.hasClass('comment-form')) { + form.submit(); + } +} + function onOAuthLoginClick() { const oauthLoader = $('#oauth2-login-loader'); const oauthNav = $('#oauth2-login-navigator'); diff --git a/templates/repo/diff/comment_form.tmpl b/templates/repo/diff/comment_form.tmpl index 38fd3fa7f..5f3bbc448 100644 --- a/templates/repo/diff/comment_form.tmpl +++ b/templates/repo/diff/comment_form.tmpl @@ -26,7 +26,8 @@ <span class="markdown-info"><i class="octicon octicon-markdown"></i> {{$.root.i18n.Tr "repo.diff.comment.markdown_info"}}</span> <div class="ui right floated"> {{if $.reply}} - <button name="reply" value="{{$.reply}}" class="ui submit green tiny button btn-reply">{{$.root.i18n.Tr "repo.diff.comment.reply"}}</button> + <input type="hidden" name="reply" value="{{$.reply}}"> + <button class="ui submit green tiny button btn-reply" onclick="submitReply(this);">{{$.root.i18n.Tr "repo.diff.comment.reply"}}</button> {{else}} {{if $.root.CurrentReview}} <button name="is_review" value="true" type="submit" |