Set max text height to prevent overflow (#18862) Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button. Before:  After:  Interestingly, I don't see this bug on Firefox.

Changes

1 changed files (+1/-1)

• web_src/js/features/repo-issue.js
  • @@ -462,7 +462,7 @@ export function initRepoPullRequestReview() {
    (async () => { // the editor's height is too large in some cases, and the panel cannot be scrolled with page now because there is `.repository .diff-detail-box.sticky { position: sticky; }` // the temporary solution is to make the editor's height smaller (about 4 lines). GitHub also only show 4 lines for default. We can improve the UI (including Dropzone area) in future - await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px'}); + await createCommentEasyMDE($reviewBox.find('textarea'), {minHeight: '80px', maxHeight: 'calc(100vh - 360px)'}); initCompImagePaste($reviewBox); })(); }