diff options
| author | wxiaoguang | 2023-03-09 23:48:52 +0800 |
|---|---|---|
| committer | GitHub | 2023-03-09 09:48:52 -0600 |
| commit | 542cec98f8c07e0f046a35f1d516807416536e74 (patch) | |
| tree | 31a6811704630fb6f057aac2193bf1f510daf19e /modules | |
| parent | e52ac62d8e645c721060e6c9a2b0ab77eedf8fd6 (diff) | |
Refactor merge/update git command calls (#23366)
Follow #22568
* Remove unnecessary ToTrustedCmdArgs calls
* the FAQ in #22678
* Quote: When using ToTrustedCmdArgs, the code will be very complex (see
the changes for examples). Then developers and reviewers can know that
something might be unreasonable.
* The `signArg` couldn't be empty, it's either `-S{keyID}` or
`--no-gpg-sign`.
* Use `signKeyID` instead, add comment "empty for no-sign, non-empty to
sign"
* 5-line code could be extracted to a common `NewGitCommandCommit()` to
handle the `signKeyID`, but I think it's not a must, current code is
clear enough.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/git/command.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/git/command.go b/modules/git/command.go index 0bc810311..9a65279a8 100644 --- a/modules/git/command.go +++ b/modules/git/command.go @@ -179,7 +179,7 @@ func (c *Command) AddDashesAndList(list ...string) *Command { } // ToTrustedCmdArgs converts a list of strings (trusted as argument) to TrustedCmdArgs -// In most cases, it shouldn't be used. Use AddXxx function instead +// In most cases, it shouldn't be used. Use NewCommand().AddXxx() function instead func ToTrustedCmdArgs(args []string) TrustedCmdArgs { ret := make(TrustedCmdArgs, len(args)) for i, arg := range args { |