diff options
| author | oliverpool | 2023-02-20 09:43:04 +0100 |
|---|---|---|
| committer | GitHub | 2023-02-20 16:43:04 +0800 |
| commit | 3596df52c09831f7f39f8416264ff267954f35a0 (patch) | |
| tree | e4234049f1337eb98db3325804b0a5ebc4b61cab /templates | |
| parent | 1d64eafe8f296e77c59c18fcda428d2b5df67ac0 (diff) | |
Fix hidden commit status on multiple checks (#22889)
Since #22632, when a commit status has multiple checks, no check is
shown at all (hence no way to see the other checks).
This PR fixes this by always adding a tag with the
`.commit-statuses-trigger` to the DOM (the `.vm` is for vertical
alignment).
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/repo/commit_statuses.tmpl | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/templates/repo/commit_statuses.tmpl b/templates/repo/commit_statuses.tmpl index 8250a8581..8858fb840 100644 --- a/templates/repo/commit_statuses.tmpl +++ b/templates/repo/commit_statuses.tmpl @@ -1,6 +1,14 @@ -{{if eq (len .Statuses) 1}}{{$status := index .Statuses 0}}{{if $status.TargetURL}}<a class="ui link commit-statuses-trigger gt-vm" href="{{$status.TargetURL}}">{{template "repo/commit_status" .Status}}</a>{{end}}{{end}} -<div class="ui commit-statuses-popup commit-statuses tippy-target"> - <div class="ui relaxed list divided"> +{{if .Statuses}} + {{if and (eq (len .Statuses) 1) .Status.TargetURL}} + <a class="gt-vm gt-tdn" data-tippy="commit-statuses" href="{{.Status.TargetURL}}"> + {{template "repo/commit_status" .Status}} + </a> + {{else}} + <span class="gt-vm" data-tippy="commit-statuses" tabindex="0"> + {{template "repo/commit_status" .Status}} + </span> + {{end}} + <div class="tippy-target ui relaxed list divided"> {{range .Statuses}} <div class="ui item singular-status gt-df"> {{template "repo/commit_status" .}} @@ -11,4 +19,4 @@ </div> {{end}} </div> -</div> +{{end}} |