aboutsummaryrefslogtreecommitdiff
path: root/web_src
diff options
context:
space:
mode:
authorwxiaoguang2023-03-08 11:26:37 +0800
committerGitHub2023-03-08 11:26:37 +0800
commitb70c7f86604185ed18a9d5e3b25327805e2b6a52 (patch)
treeae9248228bc9fbee84ca97d25680e4b667f192da /web_src
parent2dc4f80af0d9ee865711e5394295cc431f73f8c9 (diff)
Fix incorrect display for comment context menu (#23343)
Replace #23342 Fix a regression of #23014: the `a` couldn't be used here because Fomantic UI has style conflicts: `.ui.comments .comment .actions a { display: inline-block; }` And complete one more of my TODOs: "in the future there could be a special CSS class for it"
Diffstat (limited to 'web_src')
-rw-r--r--web_src/js/features/aria.js5
1 files changed, 3 insertions, 2 deletions
diff --git a/web_src/js/features/aria.js b/web_src/js/features/aria.js
index 373d667c5..46944336a 100644
--- a/web_src/js/features/aria.js
+++ b/web_src/js/features/aria.js
@@ -83,8 +83,9 @@ function attachOneDropdownAria($dropdown) {
if (e.key === 'Enter') {
let $item = $dropdown.dropdown('get item', $dropdown.dropdown('get value'));
if (!$item) $item = $menu.find('> .item.selected'); // when dropdown filters items by input, there is no "value", so query the "selected" item
- // if the selected item is clickable, then trigger the click event. in the future there could be a special CSS class for it.
- if ($item && $item.is('a')) $item[0].click();
+ // if the selected item is clickable, then trigger the click event.
+ // we can not click any item without check, because Fomantic code might also handle the Enter event. that would result in double click.
+ if ($item && ($item.is('a') || $item.is('.js-aria-clickable'))) $item[0].click();
}
});