694441feRemove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861)
* Remove customized (unmaintained) dropdown, improve aria a11y for dropdown
* fix repo permission
* use action instead of onChange
* re-order the CSS selector
* fix dropdown behavior for repo permissions, make elements inside menu item non-focusable
* use menu/menuitem instead of combobox/option. use tooltip(data-content) for aria-label, prevent from repeated attaching
* click menu item when pressing Enter
* code format
* fix repo permission
* repo setting: prevent from misleading users when error occurs
* fine tune the repo collaboration access mode dropdown (in case the access mode is undefined in the template)
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>wxiaoguang
authored at
GitHub
comitted at
1d04e864Set Setpgid on child git processes (#19865)
When Gitea is running as PID 1 git will occassionally orphan child processes leading
to (defunct) processes. This PR simply sets Setpgid to true on these child processes
meaning that these defunct processes will also be correctly reaped.
Fix #19077
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
085924b1Allow postgres integration tests to run over unix pipe (#19875)
zeripath
authored at
GitHub
comitted at
e09fb30dimprovement some release related code (#19867)
Lunny Xiao
authored at
GitHub
comitted at
0c759fd4feat: add DEFAULT_MERGE_STYLE to `repository.pull-request` section for repo init (#19751)
ttys3
authored at
GitHub
comitted at
e32ab429Prevent NPE on update mirror settings (#19864)
A `repo_model.Mirror` repository field (`.Repo`) will not automatically
be set, but is used without checking in mirror_pull.go:UpdateAddress.
This will cause an NPE.
This PR changes UpdateAddress to use the helper function GetRepository()
helping prevent future NPEs but also changes modules/context/repo.go to
ensure that the Mirror.Repo is set.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
8aaba65eOnly return valid stopwatches (#19863)
Looking through the logs of try.gitea.io I am seeing a number of reports
of being unable to APIformat stopwatches because the issueID is 0. These
are invalid StopWatches and they represent a db inconsistency.
This PR simply stops sending them to the eventsource.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
bbffddaaAdd title attribute to dependencies in sidebar (#19807)
* Add title attribute to dependencies in sidebar
Add the full title as the title attribute on dependencies in
the sidebar.
Fix #19806
Signed-off-by: Andrew Thornton <art27@cantab.net>
* as per silverwind
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
d002e3daFix spelling mistake in ProcReceive (#19853)
There was a spelling mistake in the ProcReceive handler. This PR fixes
this.
zeripath
authored at
GitHub
comitted at
730b9a5aEnsure responses are context.ResponseWriters (#19843)
In order for web.Wrap to be able to detect if a response has been written
we need to wrap any non-context.ResponseWriters as a such. Otherwise
responses will be incorrectly detected as non-written to and handlers can
double run.
In the case of GZip this handler will change the response to a non-context.RW
and this failure to correctly detect response writing causes fallthrough and
a NPE.
Fix #19839
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
0e516949Fix inconsistency in doctor output (#19836)
* Fix inconsistency in doctor output
- Use `logger.Info` instead of `logger.Warn` when no errors were found.
* Update modules/doctor/fix16961.go
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Gusted
authored at
GitHub
comitted at
40e87d03docs: recommendations to ensure backup consistency and reliability (#19845)
* docs: recommendations to ensure backup consistency and reliability
* s/stooping/stopping/
* Update docs/content/doc/usage/backup-and-restore.en-us.md
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>singuliere
authored at
GitHub
comitted at
4a295d4afeat: Add support for extra sshd_config parameters via 'Include' file (#19842)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Thomas Andrade
authored at
GitHub
comitted at
fdc784dbdocs: update the ROOT documentation and error messages (#19832)
* docs: update the ROOT documentation and error messages
* The documentation now reflects what happens in the
setting/repository.go::newRepository function:
filepath.Join(AppWorkPath, RepoRootPath) was missing.
* The error message displayed when RepoRootPath is not found now
displays the value of RepoRootPath. Given the complexity of the
construction of this value, only referring to it in the abstract
is likely to be misleading to the Gitea admin trying to interpret
the message.
Co-authored-by: delvh <dev.lh@web.de>singuliere
authored at
GitHub
comitted at
5976e3e8Add version hint in the docs when packages are available (#19838)
* Add version hint in the docs when packages are available
* Change italic to bolddelvh
authored at
GitHub
comitted at
4cac9082docs(hacking-on-gitea): fix installation instruction for elasticsearch docker (#19829)
Yehonatan Ezron
authored at
GitHub
comitted at
e0273badFix i18n for Link Account button, re-format tmpl (#19835)
wxiaoguang
authored at
GitHub
comitted at
4698a1ecAdding button to link accounts from user settings (#19792)
* Adding button to link accounts from user settings
* Only display button to link user accounts when at least one OAuth2 provider is activeMai-Lapyst
authored at
GitHub
comitted at
f2439b7efix(telegram): fix link bot to release tag (#19830)
* fix(telegram): fix link bot to release tag
* test(webhook): fix matrixPayload Release
* test(webhook): fix TestTelegramPayload ReleaseYehonatan Ezron
authored at
GitHub
comitted at