a39287cdSend mail to issue/pr assignee/reviewer also when OnMention is set (#18707)
I want to address #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.
From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?
The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?
@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?
#12774 (comment)
Fix #17892 flozzone
authored at
GitHub
comitted at
2ddff74aReduce CI go module downloads, add make targets (#18708)
The CI currently downloads all go modules in each pipeline step because
go modules reside outside the project directory. Fix this by introducing
a volume for the `/go` directory [1] so modules are only downloaded once per
pipeline using a new `deps-backend` make target.
For completeness, I also included new `deps` and `deps-frontend` targets
and the frontend one is also triggered explicitly on CI where needed.
[1] https://docs.drone.io/pipeline/kubernetes/examples/language/golang/#dependencies
silverwind
authored at
GitHub
comitted at
4e57bd1dAdd number in queue status to monitor page (#18712)
Add number in queue status to the monitor page so that administrators can
assess how much work is left to be done in the queues.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>zeripath
authored at
GitHub
comitted at
9444135fFix source code line highlighting (#18729)
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>Jimmy Praet
authored at
GitHub
comitted at
91ac65dbFix forked repositories missed tags (#18719)
* Fix forked repositories missed tags
* Add missed close
* Use ctx
Co-authored-by: 6543 <6543@obermui.de>Lunny Xiao
authored at
GitHub
comitted at
e0688995Display template path of current page in dev mode (#18717)
* Display template path of current page in dev mode
* improve code
* Update templates/base/footer_content.tmpl
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>Lunny Xiao
authored at
GitHub
comitted at
c86ecaebSeparate the details links of commit-statuses in headers (#18661)
zeripath
authored at
GitHub
comitted at
832ce406Add LDAP group sync to Teams, fixes #1395 (#16299)
* Add setting for a JSON that maps LDAP groups to Org Teams.
* Add log when removing or adding team members.
* Sync is being run on login and periodically.
* Existing group filter settings are reused.
* Adding and removing team members.
* Sync not existing LDAP group.
* Login with broken group map JSON.
Sven Seeberg
authored at
GitHub
comitted at
26718a78Change git.cmd to RunWithContext (#18693)
Change all `cmd...Pipeline` commands to `cmd.RunWithContext`.
#18553
Co-authored-by: Martin Scholz <martin.scholz@versasec.com>Martin Scholz
authored at
GitHub
comitted at
393ea86aAlways set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo (#18713)
Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.
Fix #18706
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
b2b3225bPrevent double encoding of branch names in delete branch (#18714)
* Prevent double encoding of branch names in delete branch
There is a double encoding issue in branch template whereby the branch name
ends up double encoded.
Fix #18709
Signed-off-by: Andrew Thornton <art27@cantab.net>
* and tag name
Signed-off-by: Andrew Thornton <art27@cantab.net>
* And fix #18704
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
165ab17aAttempt to improve docs (yet again) (#18687)
* Attempt to improve docs (yet again)
Attempt to make the passthrough docs clearer.
Add some more faq entries
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gusted <williamzijl7@hotmail.com>
* Update docs/content/doc/installation/with-docker.en-us.md
* Update docs/content/doc/installation/with-docker.en-us.md
Co-authored-by: Gusted <williamzijl7@hotmail.com>zeripath
authored at
GitHub
comitted at
6d11a31aMake the proformas clearer that we need DEBUG logs (#18700)
It is ridiculous how few of our bug reporter are giving us DEBUG level logs.
This has to change and I think the proforma is not making it clear enough that
they have to give us these logs.
This PR changes the issue proformas to tell people to give us these logs.
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
581d29ecUpdate SSH Server crypto settings (#18697)
- Use a better and more curated list of Ciphers and KeyExchanges, these roughly follows OpenSSH's default.
- Remove some cryptography values which were deprecated.Gusted
authored at
GitHub
comitted at
0c70b4c2Fix bug for version update hint (#18701)
Co-authored-by: silverwind <me@silverwind.io>Lunny Xiao
authored at
GitHub
comitted at
7489d96dFix issue with docker-rootless shimming script (#18690)
zeripath
authored at
GitHub
comitted at
bc8e19ectests: remove redundant comparison in repo dump/restore (#18660)
It is a leftover forgotten in https://github.com/go-gitea/gitea/pull/18621
Signed-off-by: singuliere <singuliere@autistici.org>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>singuliere
authored at
GitHub
comitted at
c917f2dfDisable unnecessary OpenID/OAuth2 elements (#18491)
This mod fixes disabling unnecessary OpenID elements.
Related: https://github.com/go-gitea/gitea/pull/13129
Author-Change-Id: IB#1115256
Paweł Bogusławski
authored at
GitHub
comitted at
eb748f5fAdd apply-patch, basic revert and cherry-pick functionality (#17902)
This code adds a simple endpoint to apply patches to repositories and
branches on gitea. This is then used along with the conflicting checking
code in #18004 to provide a basic implementation of cherry-pick revert.
Now because the buttons necessary for cherry-pick and revert have
required us to create a dropdown next to the Browse Source button
I've also implemented Create Branch and Create Tag operations.
Fix #3880
Fix #17986
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
439ad34cC preprocessor colors improvement (#18671)
* C preprocessor colors improvement
Fixes #18670
* Update web_src/less/chroma/light.less
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* typo
missing semi
* add color for #include filenames
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Bruno Raoult
authored at
GitHub
comitted at
55793455Update object repo with the migrated repository (#18684)
When migrating a repository (from GitHub) using the API (**POST** `repos/migrate`), the Code Indexer is not updated. Searching in the user interface will not return any results.
When migrating the same repository using **+/New Migration** in the web interface, the search index is updated and searching works as expected.
Caused by the fact that object `repo` is never updated with the migrated repo so `setting.Indexer.RepoIndexerEnabled && !repo.IsEmpty` in `modules/notification/indexer/indexer.go:NotifyMigrateRepository` always evaluates to `false`.
Tested with gitea:1.16.1, MariaDB:10, Breve in `Run Mode: Dev`.Hugo Hoitink
authored at
GitHub
comitted at
2f766082Prevent security failure due to bad APP_ID (#18678)
WebAuthn may cause a security exception if the provided APP_ID is not allowed for the
current origin. Therefore we should reattempt authentication without the appid
extension.
Also we should allow [u2f] as-well as [U2F] sections.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
ae0d8d94Let `MinUnitAccessMode` return correct perm (#18675)
- Don't let `TypeExternalTracker` or `TypeExternalWiki` influence the
minimal permission, as they won't be higher than read. So even if all
the other ones are write, these 2 will ensure that's not higher than
read.
- Partially resolves #18572 (Point 1,2,5?)
Co-authored-by: zeripath <art27@cantab.net>Gusted
authored at
GitHub
comitted at