Commits at 616146f90400bcf80671410c04926d9dc1f11257
616146f9Various Mermaid improvements (#18776)
* Various Mermaid improvments
- Render into iframe for improved security
- Use built-in dark theme instead of color inversion
- Remove flexbox attributes, resulting in more consistent size rendering
- Update API usage and update to latest version
* restart ci
* misc tweaks
* remove unneccesary declaration
* make it work without allow-same-origin, add loading=lazy
* remove loading attribute, does not seem to work
* rename variable
* skip roundtrip to DOM for rendering
* don't guess chart height
* update comment to make it clear it's intentional
* tweak
* replace deprecated 'scrolling' property
* remove unused css file
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>silverwind
authored at
GitHub
comitted at
4482f62aPrevent dangling GetAttribute calls (#18754)
It appears possible that there could be a hang due to unread data from the
repo-attribute command pipes. This PR simply closes these during the defer.
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
5348e198Add example to render html files (#18736)
* Add example to render html files
* Use class in example
Co-authored-by: zeripath <art27@cantab.net>Lunny Xiao
authored at
GitHub
comitted at
ecc3954dFix a broken link in `commits_list_small.tmpl` (#18763)
wxiaoguang
authored at
GitHub
comitted at
08fe6f8cFix broken cancel button link on patch page (#18718)
* Fix broken cacnel button link on patch page
* remove treepath="patch" elsewhere too
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net>
Lunny Xiao
authored at
GitHub
comitted at
581a563cIgnore the migrate if u2f_registration is not exist (#18760)
Lunny Xiao
authored at
GitHub
comitted at
32599bf0Increase the size of the webauthn_credential credential_id field (#18739)
Unfortunately credentialIDs in u2f are 255 bytes long which with base32 encoding
becomes 408 bytes. The default size of a xorm string field is only a VARCHAR(255)
This problem is not apparent on SQLite because strings get mapped to TEXT there.
Fix #18727
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
1b1658d8Fix isempty detection of git repository (#18746)
* Fix isempty detection of git repository
* Fix IsEmpty checkLunny Xiao
authored at
GitHub
comitted at
a39287cdSend mail to issue/pr assignee/reviewer also when OnMention is set (#18707)
I want to address #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.
From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?
The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?
@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?
#12774 (comment)
Fix #17892 flozzone
authored at
GitHub
comitted at
2ddff74aReduce CI go module downloads, add make targets (#18708)
The CI currently downloads all go modules in each pipeline step because
go modules reside outside the project directory. Fix this by introducing
a volume for the `/go` directory [1] so modules are only downloaded once per
pipeline using a new `deps-backend` make target.
For completeness, I also included new `deps` and `deps-frontend` targets
and the frontend one is also triggered explicitly on CI where needed.
[1] https://docs.drone.io/pipeline/kubernetes/examples/language/golang/#dependencies
silverwind
authored at
GitHub
comitted at
4e57bd1dAdd number in queue status to monitor page (#18712)
Add number in queue status to the monitor page so that administrators can
assess how much work is left to be done in the queues.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>zeripath
authored at
GitHub
comitted at
9444135fFix source code line highlighting (#18729)
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>Jimmy Praet
authored at
GitHub
comitted at
91ac65dbFix forked repositories missed tags (#18719)
* Fix forked repositories missed tags
* Add missed close
* Use ctx
Co-authored-by: 6543 <6543@obermui.de>Lunny Xiao
authored at
GitHub
comitted at
e0688995Display template path of current page in dev mode (#18717)
* Display template path of current page in dev mode
* improve code
* Update templates/base/footer_content.tmpl
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>Lunny Xiao
authored at
GitHub
comitted at
c86ecaebSeparate the details links of commit-statuses in headers (#18661)
zeripath
authored at
GitHub
comitted at
832ce406Add LDAP group sync to Teams, fixes #1395 (#16299)
* Add setting for a JSON that maps LDAP groups to Org Teams.
* Add log when removing or adding team members.
* Sync is being run on login and periodically.
* Existing group filter settings are reused.
* Adding and removing team members.
* Sync not existing LDAP group.
* Login with broken group map JSON.
Sven Seeberg
authored at
GitHub
comitted at
26718a78Change git.cmd to RunWithContext (#18693)
Change all `cmd...Pipeline` commands to `cmd.RunWithContext`.
#18553
Co-authored-by: Martin Scholz <martin.scholz@versasec.com>Martin Scholz
authored at
GitHub
comitted at
393ea86aAlways set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo (#18713)
Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.
Fix #18706
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
b2b3225bPrevent double encoding of branch names in delete branch (#18714)
* Prevent double encoding of branch names in delete branch
There is a double encoding issue in branch template whereby the branch name
ends up double encoded.
Fix #18709
Signed-off-by: Andrew Thornton <art27@cantab.net>
* and tag name
Signed-off-by: Andrew Thornton <art27@cantab.net>
* And fix #18704
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
165ab17aAttempt to improve docs (yet again) (#18687)
* Attempt to improve docs (yet again)
Attempt to make the passthrough docs clearer.
Add some more faq entries
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gusted <williamzijl7@hotmail.com>
* Update docs/content/doc/installation/with-docker.en-us.md
* Update docs/content/doc/installation/with-docker.en-us.md
Co-authored-by: Gusted <williamzijl7@hotmail.com>zeripath
authored at
GitHub
comitted at
6d11a31aMake the proformas clearer that we need DEBUG logs (#18700)
It is ridiculous how few of our bug reporter are giving us DEBUG level logs.
This has to change and I think the proforma is not making it clear enough that
they have to give us these logs.
This PR changes the issue proformas to tell people to give us these logs.
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
581d29ecUpdate SSH Server crypto settings (#18697)
- Use a better and more curated list of Ciphers and KeyExchanges, these roughly follows OpenSSH's default.
- Remove some cryptography values which were deprecated.Gusted
authored at
GitHub
comitted at