8aaba65eOnly return valid stopwatches (#19863)
Looking through the logs of try.gitea.io I am seeing a number of reports
of being unable to APIformat stopwatches because the issueID is 0. These
are invalid StopWatches and they represent a db inconsistency.
This PR simply stops sending them to the eventsource.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
bbffddaaAdd title attribute to dependencies in sidebar (#19807)
* Add title attribute to dependencies in sidebar
Add the full title as the title attribute on dependencies in
the sidebar.
Fix #19806
Signed-off-by: Andrew Thornton <art27@cantab.net>
* as per silverwind
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
d002e3daFix spelling mistake in ProcReceive (#19853)
There was a spelling mistake in the ProcReceive handler. This PR fixes
this.
zeripath
authored at
GitHub
comitted at
730b9a5aEnsure responses are context.ResponseWriters (#19843)
In order for web.Wrap to be able to detect if a response has been written
we need to wrap any non-context.ResponseWriters as a such. Otherwise
responses will be incorrectly detected as non-written to and handlers can
double run.
In the case of GZip this handler will change the response to a non-context.RW
and this failure to correctly detect response writing causes fallthrough and
a NPE.
Fix #19839
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
0e516949Fix inconsistency in doctor output (#19836)
* Fix inconsistency in doctor output
- Use `logger.Info` instead of `logger.Warn` when no errors were found.
* Update modules/doctor/fix16961.go
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Gusted
authored at
GitHub
comitted at
40e87d03docs: recommendations to ensure backup consistency and reliability (#19845)
* docs: recommendations to ensure backup consistency and reliability
* s/stooping/stopping/
* Update docs/content/doc/usage/backup-and-restore.en-us.md
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>singuliere
authored at
GitHub
comitted at
4a295d4afeat: Add support for extra sshd_config parameters via 'Include' file (#19842)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Thomas Andrade
authored at
GitHub
comitted at
fdc784dbdocs: update the ROOT documentation and error messages (#19832)
* docs: update the ROOT documentation and error messages
* The documentation now reflects what happens in the
setting/repository.go::newRepository function:
filepath.Join(AppWorkPath, RepoRootPath) was missing.
* The error message displayed when RepoRootPath is not found now
displays the value of RepoRootPath. Given the complexity of the
construction of this value, only referring to it in the abstract
is likely to be misleading to the Gitea admin trying to interpret
the message.
Co-authored-by: delvh <dev.lh@web.de>singuliere
authored at
GitHub
comitted at
5976e3e8Add version hint in the docs when packages are available (#19838)
* Add version hint in the docs when packages are available
* Change italic to bolddelvh
authored at
GitHub
comitted at
4cac9082docs(hacking-on-gitea): fix installation instruction for elasticsearch docker (#19829)
Yehonatan Ezron
authored at
GitHub
comitted at
e0273badFix i18n for Link Account button, re-format tmpl (#19835)
wxiaoguang
authored at
GitHub
comitted at
4698a1ecAdding button to link accounts from user settings (#19792)
* Adding button to link accounts from user settings
* Only display button to link user accounts when at least one OAuth2 provider is activeMai-Lapyst
authored at
GitHub
comitted at
f2439b7efix(telegram): fix link bot to release tag (#19830)
* fix(telegram): fix link bot to release tag
* test(webhook): fix matrixPayload Release
* test(webhook): fix TestTelegramPayload ReleaseYehonatan Ezron
authored at
GitHub
comitted at
8720f876Make WIP prefixes case insensitive, e.g. allow `Draft` as a WIP prefix (#19780)
The issue was that only the actual title was converted to uppercase, but
not the prefix as specified in `WORK_IN_PROGRESS_PREFIXES`. As a result,
the following did not work:
WORK_IN_PROGRESS_PREFIXES=Draft:,[Draft],WIP:,[WIP]
One possible workaround was:
WORK_IN_PROGRESS_PREFIXES=DRAFT:,[DRAFT],WIP:,[WIP]
Then indeed one could use `Draft` (as well as `DRAFT`) in the title.
However, the link `Start the title with DRAFT: to prevent the pull request
from being merged accidentally.` showed the suggestion in uppercase; so
it is not possible to show it as `Draft`. This PR fixes it, and allows
to use `Draft` in `WORK_IN_PROGRESS_PREFIXES`.
Fixes #19779.
Co-authored-by: zeripath <art27@cantab.net>Ondřej Čertík
authored at
GitHub
comitted at
0692f437Show source/target branches on PR's list (#19747)
Add ability to show source/target branches for Pull Request's list. It can be useful to see which branches are used in each PR right in the list.
Co-authored-by: Alexey Korobkov <akorobkov@cian.ru>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>IT-AlexKor
authored at
GitHub
comitted at
35d0358cGithub style following followers (#19482)
Removed tabbed following and followers from user page and added Github style following followers.istiak101
authored at
GitHub
comitted at
0cbec3cdalpine 3.16 (#19797)
Co-authored-by: 6543 <6543@obermui.de>techknowlogick
authored at
GitHub
comitted at
93ab9074Prevent loop if there is an error in GetNotificationCount (#19799)
If the context is cancelled `.NotificationUnreadCount` in a template can
cause an infinite loop with `ctx.ServerError()` being called, which
creates a template that then calls `.NotificationUnreadCount` calling
`GetNotificationCount()` with the cancelled context resulting in an
error that calls `ctx.ServerError`... and so on...
This PR simply stops calling `ctx.ServerError` in the error handler code
for `.NotificationUnreadCount` as we have already started rendering and
so it is too late to call `ctx.ServerError`. Additionally we skip
logging the error if it's a context cancelled error.
Fix #19793
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
b24db66aAdd 'make tidy' (#19800)
Convenience command to run 'go mod tidy'. The compat flag is set to the
minimum supported go version instead of min version minus one which is
go's default, which eliminated some checksums in go.sum as a result.silverwind
authored at
GitHub
comitted at
4266bd92Update document to use FHS `/usr/local/bin/gitea` instead of `/app/...` for Docker (#19794)
* Update document to use FHS `/usr/local/bin/gitea` instead of `/app/...` in Docker
* Update docs/content/doc/installation/with-docker.zh-cn.mdwxiaoguang
authored at
GitHub
comitted at