1. Top
  2. gitea
  3. Commits
gitea

Development moved to Codeberg

Commits at 7ba1b7112f47a2025e8538509a24d8c6d5b1f488

  1. 7ba1b711 Only attempt to flush queue if the underlying worker pool is not finished (#18593) * Only attempt to flush queue if the underlying worker pool is not finished There is a possible race whereby a worker pool could be cancelled but yet the underlying queue is not empty. This will lead to flush-all cycling because it cannot empty the pool. Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> zeripath authored at GitHub comitted at
  2. a51d2114 quote MAKE to prevent path expansion with space error (#18622) Pretty minor change to prevent error when `$(MAKE)` path is expanded with a space in the path. ```bash $ TAGS="bindata sqlite sqlite_unlock_notify" make build /usr/bin/sh: -c: line 0: syntax error near unexpected token `(' /usr/bin/sh: -c: line 0: `C:/Program Files (x86)/GnuWin32/bin/make -v | head -n 1' ``` I believe Program Files (x86) is the default path for GNU make on windows Kyle D authored at GitHub comitted at
  3. 933e8191 Ensure that blob-excerpt links work for wiki (#18587) It appears that the blob-excerpt links do not work on the wiki - likely since their introduction. This PR adds support for the wiki on these links. Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  4. aa23f477 Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439) - Switch to use `CryptoRandomBytes` instead of `CryptoRandomString`, OAuth's secrets are copied pasted and don't need to avoid dubious characters etc. - `CryptoRandomBytes` gives ![2^256 = 1.15 * 10^77](https://render.githubusercontent.com/render/math?math=2^256%20=%201.15%20\cdot%2010^77) `CryptoRandomString` gives ![62^44 = 7.33 * 10^78](https://render.githubusercontent.com/render/math?math=62^44%20=%207.33%20\cdot%2010^78) possible states. - Add a prefix, such that code scanners can easily grep these in source code. - 32 Bytes + prefix Gusted authored at GitHub comitted at
  5. 88939a56 Remove the spurious space in the .ui.right additional selector (#18605) Somehow a spurious space sneaked in to #18538 this PR simply removes it. Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  6. 3c737410 Ensure commit-statuses box is sized correctly in headers (#18538) * Ensure commit-statuses box is sized correctly in headers When viewing commits as commits the commit-status box will be fixed at 30px in height due to being forced to be this size by a fomantic selector. This PR simply adds a few more selectors to force this to have height auto. Fix #18498 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update web_src/less/_repository.less Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> zeripath authored at GitHub comitted at
  7. 319d191a [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  8. 1ab44cb0 Prevent merge messages from being sorted to the top of email chains (#18566) * Prevent merge messages from being sorted to the top of email chains Gitea will currrently resend the same message-id for the closed/merged/reopened messages for issues. This will cause the merged message to leap to the top of an email chain and become out of sync. This PR adds specific suffices for these actions. Fix #18560 Signed-off-by: Andrew Thornton <art27@cantab.net> * add test Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  9. 9f9ca0aa Fix pushing to 1-x-dev docker tag (#18578) * Fix pushing to 1-x-dev docker tag It appears that #18551 and #18573 have a mistake in that raymond does not have an {{else}} on {{#equal}}. This PR notes that Sprig has a hasPrefix function and so we use this with another if. Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix pushing to 1-x-dev docker tag (part 2) Although we now have the manifest working, we need to create the images. Here we adjust the .drone.yml to force building of the images Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix pushing to 1-x-dev docker tag OK now we have the images building we should make sure that the main ones stays dev and the release/v* ones become *-dev-* Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review zeripath authored at GitHub comitted at
  10. cafd19c1 Replace `sync.Map` with normal maps (#18584) * Replace `sync.Map` with normal maps - These maps aren't being used in any kind of concurrent read/write and thus don't need `sync.Map` and can instead use normal maps. - Special thanks to dachary. - Added in: https://github.com/go-gitea/gitea/pull/6290 * Remove unannounced feature Gusted authored at GitHub comitted at
  11. e2bbbc48 Fix oauth docs usage for 2fa (#18581) Sambhav Saggi authored at GitHub comitted at
  12. 90b4d385 Update .gitattributes for .tmpl files (#18576) There are a few .tmpl files outside the templates directory. Match these as well by using `*.tmpl` glob in `.gitattributes`. Also, sort the file alphabetically. silverwind authored at GitHub comitted at
  13. 1c5afd17 Prevent panic on prohibited user login with oauth2 (#18562) There was an unfortunate regression in #17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix #18561 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  14. 104c547d Fix manifest.tmpl (#18573) A spurious {{/if}} appeared on the manifest.tmpl - this PR simply removes this. Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  15. bc77b28d Make docker gitea/gitea:v1.16-dev etc refer to the latest build on that branch (#18551) * Make docker gitea/gitea:v1.16-dev etc refer to the latest build on that branch One of the problems with our current docker tagging is that although we have strict version tags, latest and dev we do not have a way for docker users to track the current release branch. This PR simply suggests that we use the 1.x-dev tag for these and we build and push these. This will give users who want or need unreleased bug fixes the option of tracking the pre-release version instead of simply jumping to dev. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> zeripath authored at GitHub comitted at
  16. c8c59107 Add dropdown icon to template loading dropdown (#18564) Fixes #15679 and the dupe of it: Fixes #16364. Also removes a comment that links to a gogs forum thread. fnetX (aka fralix) authored at GitHub comitted at
  17. 76e31115 Collaborator trust model should trust collaborators (#18539) * Collaborator trust model should trust collaborators There was an unintended regression in #17917 which leads to only repository admin commits being trusted. This PR restores the old logic. Fix #18501 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  18. 92e81e97 Detect conflicts with 3way merge (#18536) * Detect conflicts with 3way merge Unforunately git apply --3way reports conflicts differently than standard patches resulting in conflicts being missed. Adjust the conflict detection code to account for this different error reporting. Fix #18514 Signed-off-by: Andrew Thornton <art27@cantab.net> * and three-way failed Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> zeripath authored at GitHub comitted at
  19. 5469e61a [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  20. f192b905 Update 1.16.0 changelog to set #17846 as breaking (#18533) Unfortunately #17846 was determined to be breaking due to affecting ssh passthrough however, this discovery happened after the changelog was created. Update the Changelog to mark this as breaking. Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  21. de05d71b In docker rootless use $GITEA_APP_INI if provided (#18524) Michael Kriese authored at GitHub comitted at
  22. 24d39ee6 revert to node14 for snapcraft techknowlogick authored at GitHub comitted at
  23. d3b31cc1 Add `GetUserTeams` (#18499) * COrrect use `UserID` in `SearchTeams` - Use `UserID` in the `SearchTeams` function, currently it was useless to pass such information. Now it does a INNER statement to `team_user` which obtains UserID -> TeamID data. - Make OrgID optional. - Resolves #18484 * Seperate searching specific user * Add condition back * Use correct struct type Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Gusted authored at GitHub comitted at
  24. f6f4e1dd Fix review excerpt (#18502) Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0. When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files The problem occurs for the unified view and for the split view. Kind of the same problem was there for commenting a line of code, this was fixed in #18321 and #18403. For consistency, I changed the solution of #18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view. Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment Fix #18516 Co-authored-by: Andrew Thornton <art27@cantab.net> confusedsushi authored at GitHub comitted at
  25. 99e1e30b Update JS dependencies, fix lint (#18389) - Update all JS dependencies, including a security issue in mermaid - Fix new linter errors related to value-keyword-case - Tested Mermaid and Swagger Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> silverwind authored at GitHub comitted at
  26. 367894ad add test coverage for original author conversion during migrations (#18506) * add test coverage for original author conversion during migrations And create a function to factorize a code snippet that is repeated five times and would otherwise be more difficult to test and maintain consistently. Signed-off-by: Loïc Dachary <loic@dachary.org> * fix variable scope and int64 formatting * add missing calls to remapExternalUser and fix misplaced %d Co-authored-by: Loïc Dachary <loic@dachary.org> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> singuliere authored at GitHub comitted at
  27. 6f6b8491 add gitea-fmt back (#18526) 6543 authored at GitHub comitted at
  28. bb5f859e Fix non-ASCII search on database (#18437) Use `ToASCIIUpper` for SQLite database on issues search, this because `UPPER(x)` on SQLite only transforms ASCII letters. Resolves #18429 Gusted authored at GitHub comitted at
  29. 7f2530e0 Use "read" value for General Access (#18496) - Currently the `.Team.AccessMode` is being used when editing a team, if you want to admin -> General Access, the value of General Access is "admin" which is incorrect. - Resolves #18483 (First bug mentioned) Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Gusted authored at GitHub comitted at
  30. 80048c09 Fix for AvatarURL database type (#18487) Viktor Kuzmin authored at GitHub comitted at