Commits at 93ab90743d27f292eb7e8413e5ef1c6b10a65292
93ab9074Prevent loop if there is an error in GetNotificationCount (#19799)
If the context is cancelled `.NotificationUnreadCount` in a template can
cause an infinite loop with `ctx.ServerError()` being called, which
creates a template that then calls `.NotificationUnreadCount` calling
`GetNotificationCount()` with the cancelled context resulting in an
error that calls `ctx.ServerError`... and so on...
This PR simply stops calling `ctx.ServerError` in the error handler code
for `.NotificationUnreadCount` as we have already started rendering and
so it is too late to call `ctx.ServerError`. Additionally we skip
logging the error if it's a context cancelled error.
Fix #19793
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
b24db66aAdd 'make tidy' (#19800)
Convenience command to run 'go mod tidy'. The compat flag is set to the
minimum supported go version instead of min version minus one which is
go's default, which eliminated some checksums in go.sum as a result.silverwind
authored at
GitHub
comitted at
4266bd92Update document to use FHS `/usr/local/bin/gitea` instead of `/app/...` for Docker (#19794)
* Update document to use FHS `/usr/local/bin/gitea` instead of `/app/...` in Docker
* Update docs/content/doc/installation/with-docker.zh-cn.mdwxiaoguang
authored at
GitHub
comitted at
b65ad70fAdd the possibility to allow the user to have a favicon which differs from the main logo (#18542)
* Changed the filename of the favicon SVG
This allows the user to have a favicon which differs from the logo.
* Added favicon.svg
This is needed to accommodate the changes for allowing the user to have a differing logo and favicon
* Adjusted page to accommodate what icon is used as favicon
* Added functionality to also generate the favicon.svg via generate-images.js
* Adjusted the description for the new favicon compatibility
Co-authored-by: silverwind <me@silverwind.io>
* Updated generate-images.js to generate favicons from a separate favicons.svg file
This belongs to PR #18542.
* Added description on how custom favicons can be generated
* Replaced space indents with tabs
* Synced changes with current state of the file
* Synced changes with current state of the file
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>Jan-Eric Schober
authored at
GitHub
comitted at
ffb7ab31Estimate Action Count in Statistics (#19775)
zeripath
authored at
GitHub
comitted at
468387e9Prevent NPE when cache service is disabled (#19703)
The cache service can be disabled - at which point ctx.Cache will be nil
and the use of it will cause an NPE.
The main part of this PR is that the cache is used for restricting
resending of activation mails and without this we cache we cannot
restrict this. Whilst this code could be re-considered to use the db and
probably should be, I think we can simply disable this code in the case
that the cache is disabled.
There are also several bug fixes in the /nodeinfo API endpoint.
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
bc4764ffDetect truncated utf-8 characters at the end of content as still representing utf-8 (#19773)
Our character detection algorithm can potentially incorrectly detect utf-8 as iso-8859-x
if there is a truncated character at the end of the partially read file.
This PR changes the detection algorithm to truncated utf8 characters at the end of the
buffer.
Fix #19743
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
f6c99297Add silentcodeg to MAINTAINERS (#19771)
* Add silentcodeg to MAINTAINERS
* add missing trailing g to chat nick
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>silentcodeg
authored at
GitHub
comitted at
876cad00Allows repo search to match against "owner/repo" pattern strings (#19754)
* Allows repo search to match against "owner/repo" pattern strings
* Gofumpt
* Adds test case for "owner/repo" style repo search
* With "owner/repo" search terms, prioritise results which match the owner field
* Fixes unquoted SQL string in repo searchEekle
authored at
GitHub
comitted at
ba7750d6Update JS dependencies (#19767)
- Update all JS dependencies minus Vue
- Tested mermaid, swagger, build
Co-authored-by: 6543 <6543@obermui.de>silverwind
authored at
GitHub
comitted at
a9af93cbNuke the incorrect permission report on /api/v1/notifications (#19761)
The permissions created in convertRepo use a minimal perm.AccessModeRead instead of
correctly computing the permission for the repository. This incorrect permission is
then reported to the user.
I do not believe that reporting the permissions is helpful and therefore I propose
we simply null these out. The user can check their permissions using a different
endpoint.
Fix #19759
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
fd7d83acMove almost all functions' parameter db.Engine to context.Context (#19748)
* Move almost all functions' parameter db.Engine to context.Context
* remove some unnecessary wrap functionsLunny Xiao
authored at
GitHub
comitted at
d81e31adMove org functions (#19753)
* Move org functions
* Fix commentLunny Xiao
authored at
GitHub
comitted at
63f6e6c0[doctor] pq: syntax error at or near "." quote user table name (#19765)
silentcodeg
authored at
GitHub
comitted at
2c66bd8a[doctor] update the help with fix capabilities (#19762)
* [doctor] update the help with fix capabilitiessilentcodeg
authored at
GitHub
comitted at
ac8bee6aRemove fomantic progress module (#19760)
Replace it with HTML `<progress>` element. The bar won't go green at
100% anymore but I think it's not something that fits stylistically anyways.silverwind
authored at
GitHub
comitted at
cc7236e8Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (#19729)
* Make Ctrl+Enter (quick submit) work for issue comment and wiki editor
* Remove the required `SubmitReviewForm.Type`, empty type (triggered by quick submit) means "comment"
* Merge duplicate codewxiaoguang
authored at
GitHub
comitted at
3b359b16Enable packages by default again (as described by docs) (#19746)
delvh
authored at
GitHub
comitted at
9da3d78eReplace blue button and label classes with primary (#19763)
* make blue really blue
* replace blue button and label classes with primary
* add --color-blue-dark
* add light color variants, tweak a few colors
* fix colors
* add comment
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>silverwind
authored at
GitHub
comitted at
ce525147Fix org package owner permissions (#19742)
Old code did not respect owner visibility and the organization access calculation was wrong if the user was not a member.KN4CK3R
authored at
GitHub
comitted at
3e5ea9a9Update base.go (#19739)
use http.StatusTemporaryRedirect(307) when serve avatar directly
browser caches 301 redirections, pre-signed s3 url would expire at some later point
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Guo Y.K
authored at
GitHub
comitted at
c27268db[doctor] do not update User Stars numbers unless --fix (#19750)
silentcodeg
authored at
GitHub
comitted at
ad551bffFix incorrect translation key (#19744)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>delvh
authored at
GitHub
comitted at
260a28d8Improved ref comment link when origin is body/title (#19741)
* Makes comments in body text/title return the base page URL instead of "" in RefCommentHTMLURL()
* Add comment explaining branch
Co-authored-by: delvh <dev.lh@web.de>Eekle
authored at
GitHub
comitted at
6a052fba[doctor] explain what enable-push-options does (#19740)
silentcodeg
authored at
GitHub
comitted at
e82db15cAdd doctor orphan check for orphaned pull requests without an existing base repo (#19731)
silentcodeg
authored at
GitHub
comitted at
9ea92064ContainerRegistry - removed Basic Auth header (#19735)
* Removed Basic Auth header.
* Fixed test.KN4CK3R
authored at
GitHub
comitted at