summaryrefslogtreecommitdiff
AgeCommit message (Expand)Author
2020-07-11Changelog for v1.12.2 (#12214)•••* Changelog for v1.12.2 * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Update CHANGELOG.md Co-authored-by: mrsdizzie <info@mrsdizzie.com> Co-authored-by: mrsdizzie <info@mrsdizzie.com>v1.12.2Lauris BH
2020-07-08Decrease the num_stars when deleting a repo (#11954) (#12188)•••* Decrease the num_stars when deleting a repo fix #11949 Signed-off-by: a1012112796 <1012112796@qq.com> * Add migration * use batch * Apply suggestions from code review Co-authored-by: Lauris BH <lauris@nix.lv> * fix lint * fix lint * fix ci * fix ci2 * add doctor * duplicate code * fix migration * fix some nits * add start Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>赵智超
2020-07-08Fix regression: Gitea commits API again returns commit summaries, not full me...•••Closes #12185 Co-authored-by: Kristian Antonsen <kristian@derfor.dk>techknowlogick
2020-07-08properly set symbolic-ref HEAD when a repo is created with a non-master defau...•••This fixes an issue I noticed with #10803: when you create a repo with a non-master default branch, gitea doesn't change the remote ref HEAD, so it still points at refs/heads/master. As a result, cloning my repos gives me error messages and doesn't check out the desired default branch, so I need to manually check it out after cloning. Co-authored-by: xenofem <45297511+xenofem@users.noreply.github.com>techknowlogick
2020-07-07Trim to 255 runes instead of bytes (#12150)•••* Trim to 255 runes instead of bytes Prevents invalid UTF-8 encoding for Description and Website. Refs #7905 * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv> Jürgen Hötzel
2020-07-06Ensure Subkeys are verified (#12155) (#12168)•••Backport #12155 When attempting to verify subkeys the email address verification step requires checking the emails however, these emails are not stored on subkeys but instead on the primary key. This PR will obtain the primaryKey and check against these emails too. Fix #12128 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
2020-07-06Use hash of repo path, ref and entrypath as cache key (#12151) (#12161)Lauris BH
2020-07-05Multiple small admin dashboard fixes (#12153) (#12156)•••* Prevent (EXTRA string) comments in Task headers * Redirect tasks started from monitor page back to monitor * Fix #12107 - redirects from process cancel should use AppSubUrl * When wrapping queues set the name correctly Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-07-05Remove spurious logging (#12139) (#12148)•••Backport #12139 Unfortunately #10745 merged a spurious logging message. This PR removes this. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
2020-07-05templates/repo/empty.tmpl : fix repo setup instructions (#12147)•••Co-authored-by: codeberg <codeberg@codeberg.org> Co-authored-by: zeripath <art27@cantab.net>Andreas Shimokawa
2020-07-05 Move EventSource to SharedWorker (#12095) (#12130)•••* Move EventSource to SharedWorker (#12095) Backport #12095 Move EventSource to use a SharedWorker. This prevents issues with HTTP/1.1 open browser connections from preventing gitea from opening multiple tabs. Also allow setting EVENT_SOURCE_UPDATE_TIME to disable EventSource updating Fix #11978 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Bugfix for shared event source For some reason our eslint configuration is not working correctly and a bug has become apparent when trying to backport this to 1.12. Signed-off-by: Andrew Thornton <art27@cantab.net> * Re-fix #12095 again Unfortunately some of the suggested changes to #12095 introduced bugs which due to caching behaviour of sharedworkers were not caught on simple tests. These are as follows: * Changing from simple for loop to use includes here: ```js register(port) { if (!this.clients.includes(port)) return; this.clients.push(port); port.postMessage({ type: 'status', message: `registered to ${this.url}`, }); } ``` The additional `!` prevents any clients from being added and should read: ```js if (this.clients.includes(port)) return; ``` * Dropping the use of jQuery `$(...)` selection and using DOM `querySelector` here: ```js async function receiveUpdateCount(event) { try { const data = JSON.parse(event.data); const notificationCount = document.querySelector('.notification_count'); if (data.Count > 0) { notificationCount.classList.remove('hidden'); } else { notificationCount.classList.add('hidden'); } notificationCount.text() = `${data.Count}`; await updateNotificationTable(); } catch (error) { console.error(error, event); } } ``` Requires that `notificationCount.text()` be changed to use `textContent` instead. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
2020-07-03Fix ui bug in wiki commit page (#12089) (#12125)•••* Fix ui bug in wiki commit page TODO: Maybe we should allow wiki to have its own ``.editorconfig`` file. Signed-off-by: a1012112796 <1012112796@qq.com> * fix a small nit Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net>赵智超
2020-07-02Set the base url when migrating from Gitlab using access token or username wi...•••Backport #11852 When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password Fix #11851 Co-authored-by: Gernot Eger <gernot.eger@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
2020-07-02Fix gitgraph branch continues after merge (#12044) (#12105)•••Backport #12044 * Fix gitgraph branch continues after merge After fixing the initial problem in #11981 another problem has come to light... Fix #11981 (part 2) Signed-off-by: Andrew Thornton <art27@cantab.net> * Update web_src/js/vendor/gitgraph.js * Apply suggestions from code review Co-authored-by: silverwind <me@silverwind.io> zeripath
2020-07-02Fix merge section in dark theme (#12086) (#12109)•••Backport #12086 * Fix merge section in dark theme * Fix lintLauris BH
2020-07-01Ensure BlameReaders close at end of request (#12102) (#12103)•••Backport #12102 this was thought to be due to timeouts, however on closer look this appears to be due to the Close() function of the BlameReader hanging with a blocked stdout pipe. This PR fixes this Close function to: * Cancel the context of the cmd * Close the StdoutReader - ensuring that the output pipe is closed Further it makes the context of the `git blame` command a child of the request context - ensuring that even if Close() is not called, on cancellation of the Request the blame is command will also be cancelled. Fixes #11716 Closes #11727 Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-06-28Disable go module when downloading global binaries (#12030) (#12084)•••Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once https://github.com/golang/go/issues/30515 is fixed, we should is whatever solution is provided there. Fixes: https://github.com/go-gitea/gitea/pull/12010 Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>Stefan Bethke
2020-06-25Fix comments webhook panic backport (#12058)•••* Handle HookIssueReviewed action in webhook * Fix webhook comment handling type cast panicCornel
2020-06-24Disable dropzone's timeout (#12024) (#12032)•••Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: https://github.com/go-gitea/gitea/pull/10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: https://github.com/go-gitea/gitea/issues/12022 Fixes: https://github.com/go-gitea/gitea/issues/11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>silverwind
2020-06-22Changelog for v1.12.1 (#12006)v1.12.1Lauris BH
2020-06-21Handle multiple merges in gitgraph.js (#11996) (#12000)•••Backport #11996 There is a bug in web_src/js/vendor/gitgraph.js whereby it fails to handle multiple merges in a single commit correctly. This PR adds changes to make this work. Fix #11981 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath
2020-06-20Add serviceworker.js to KnownPublicEntries (#11992) (#11994)•••Fixes a wrong 302 redirect to the login page, see https://github.com/go-gitea/gitea/issues/11989. Also made it so the reserved username list is extended with those known entries so we avoid code duplication.silverwind
2020-06-19For language detection do not try to analyze big files by content (#11971) (#...Lauris BH
2020-06-18Fix scrollable header on dropdowns (#11893) (#11965)•••Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lauris BH <lauris@nix.lv> (cherry picked from commit 1fb783efb0dbb3cb866f37ee6b77a003b636de59)Cirno the Strongest
2020-06-18Changelog v1.12.0 (#11927)•••* merge RC-logs * Update * Update CHANGELOG.md Co-authored-by: techknowlogick <techknowlogick@gitea.io>v1.12.06543
2020-06-18Changelog v1.11.7 (#11953) (#11955)•••* Changelog v1.11.7 * Update CHANGELOG.md6543
2020-06-18Fix commenting on non-utf8 encoded files (#11916) (#11950)•••* Add comment on non-unicode line to force fail Signed-off-by: Andrew Thornton <art27@cantab.net> * Just quote/unquote patch Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>6543
2020-06-18Use google/uuid to instead satori/go.uuid (#11943) (#11946)•••Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net>Lunny Xiao
2020-06-18Align show/hide outdated button on code review block (#11932) (#11944)•••Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit 6c38f371ea3ed98a2ed0534261f5d175c11c628d)Cirno the Strongest
2020-06-18[Backport] Update to go-git v5.1.0 (#11936) (#11941)•••* update go-git 5.0.0 -> v5.1.0 * vendor Co-authored-by: techknowlogick <techknowlogick@gitea.io>6543
2020-06-17Global default branch setting (#11918) (#11937)•••* Global default branch setting (#11918) * Global default branch setting * add to app.ini example per @silverwind * update per @lunny Co-authored-by: John Olheiser <john.olheiser@gmail.com> * Update modules/setting/repository.go Co-authored-by: John Olheiser <john.olheiser@gmail.com>techknowlogick
2020-06-17Use ID or Where to instead directly use Get when load object from database (#...•••Backport #11925 Use ID or Where to instead directly use Get when load object from database Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> 6543
2020-06-16Update CommitsAhead CommitsBehind on Pull BaseBranch Change too (#11912) (#11...•••* Update CommitsAhead CommitsBehind on Pull BaseBranch Change too (#11912) * CI.restart()6543
2020-06-15Invalidate comments when file is shortened (#11882) (#11884)•••Backport #11882 Fix #10686 Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-06-13Rework api/user/repos for pagination (#11827) (#11877)•••* Add count to `GetUserRepositories` so that pagination can be supported for `/user/{username}/repos` * Rework ListMyRepos to use models.SearchRepository ListMyRepos was an odd one. It first fetched all user repositories and then tried to supplement them with accessible map. The end result was that: * Limit for pagination did not work because accessible repos would always be appended * The amount of pages was incorrect if one were to calculate it * When paginating, all accessible repos would be shown on every page Hopefully it should now work properly. Fixes #11800 and does not require any change on Drone-side as it can properly interpret and act on Link header which we now set. Co-authored-by: Lauris BH <lauris@nix.lv> (cherry picked from commit 0159851cc3fa80e4df4908a5e760afa20452f712)Cirno the Strongest
2020-06-12Handle more pathological branch and tag names (#11843) (#11863)•••Backport #11843 It's possible to push quite pathological appearing branch names to gitea using git push gitea reasonable-branch:refs/heads/-- at which point large parts of the UI will break. Similarly you can git push origin reasonable-tag:refs/tags/-- which wil return an error. This PR fixes the problems these cause. It also changes the code from creating branches to pushing to ensure that branch restoration has to pass hooks. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
2020-06-12Fix search form button overlap (#11840) (#11864)•••Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit 8770bceafa3844a97f35d3f8a35089438bf2f33b)Cirno the Strongest
2020-06-11Add doctor check to set IsArchived false if it is null (partial backport #118...•••Partial backport of #11853 Add doctor check to set IsArchived false if it is null. (Migration change unfortunately not possible to be backported.) Fix #11824 Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-06-11Prevent panic on empty HOST for mysql (#11850) (#11856)•••Backport #11850 Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-06-10Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (#11831) ...•••Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit 2b2b3e4c3726ef224e87bb444340bebd3a70badb)Cirno the Strongest
2020-06-09Fix reply octicon (#11821) (#11822)•••Signed-off-by: jolheiser <john.olheiser@gmail.com>John Olheiser
2020-06-09Honor DEFAULT_PAGING_NUM for API (#11805) (#11813)•••* Honor DEFAULT_PAGING_NUM for API * set pagination to 10 for tests * lint Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit cefbf73aea912c510a8dd194532233076b822d37)Cirno the Strongest
2020-06-08Ensure rejected push to refs/pull/index/head fails nicely (#11724) (#11809)•••Backport #11724 A pre-receive hook that rejects pushes to refs/pull/index/head will cause a broken PR which causes an internal server error whenever it is viewed. This PR handles prevents the internal server error by handling non-existent pr heads and sends a flash error informing the creator there was a problem. Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
2020-06-08Changelog v1.12.0-rc2 (#11799)•••* Update * format * seperate * Update CHANGELOG.md Co-authored-by: techknowlogick <matti@mdranta.net> * Update CHANGELOG.md Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>v1.12.0-rc26543
2020-06-07Make tabular menu styling consistent for arc-green (#11570) (#11798)•••* Make tabular menu styling consistent for arc-green * rework completely * transparent borders * use darker color for active item; override only colors for borders * Update web_src/less/themes/theme-arc-green.less Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: zeripath <art27@cantab.net> (cherry picked from commit 4395c607ed79985602a99dda251f090fbd2f5cf9)Cirno the Strongest
2020-06-07Add option to API to update PullRequest base branch (#11666) (#11796)•••* EditPull: add option to change base Close #11552 Co-authored-by: Lauris BH <lauris@nix.lv>6543
2020-06-07In File Create/Update API return 404 if Branch does not exist (#11791) (#11795)•••* In File Create/Update API return 404 if Branch does not exist (#11791) * v1.12 version ;)6543
2020-06-07Fix doer of rename repo (#11789) (#11794)•••fix #11725 Signed-off-by: a1012112796 <1012112796@qq.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>赵智超
2020-06-07Increase maximum SQLite variables count to 32766 (#11696) (#11783)•••* Increase maximum SQLite variables count to 32766 (#11696) per https://www.sqlite.org/limits.html Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit a5aa5c58c1bf5a0c91226e0cbbd7b95bb8f74692) * Fix missing CGO_EXTRA_FLAGS build arg for docker Co-authored-by: techknowlogick <techknowlogick@gitea.io>Cirno the Strongest
2020-06-06Initialize SimpleMDE when making a code comment (#11749) (#11785)•••Backport #11749 Fix #11704 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-Authored-By: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath