1. Top
  2. gitea
  3. Commits
gitea

Development moved to Codeberg

Commits at fa73cbf5a7e84fab50ad5c8f3095b4dec8b4e879

  1. fa73cbf5 Store the foreign ID of issues during migration (#18446) Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table. At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists. The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps: 1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes) 2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists 3. Optimize the Gitea uploader to speed up the updates, when possible. The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it. The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration. The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works. The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together. The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo. The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not. The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose. The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues. --- [source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36) Signed-off-by: Loïc Dachary <loic@dachary.org> Co-authored-by: Loïc Dachary <loic@dachary.org> Aravinth Manivannan authored at GitHub comitted at
  2. a7de80db Remove italics for `due_date_not_set` (#19113) To be more consistent with other `repo.issues.x` formatting, we can remove the italics from `dute_date_not_set`. MeIchthys authored at GitHub comitted at
  3. cc6ff742 [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  4. df31ac0e Fixed log path in fail2ban documentation (#19103) This updates the log path in the [gitea-docker] jail configuration to match the path in the [gitea] jail, which was updated in #13726. Fredrik Ekre authored at GitHub comitted at
  5. 0b15a729 rm .sample hooks which aren't used (#19101) techknowlogick authored at GitHub comitted at
  6. ed1d95c5 use go1.18 to build gitea (#19099) * use go1.18 to build gitea& update min go version to 1.17 * bump in a few more places * add a few simple tests for isipprivate * update go.mod * update URL to https://go.dev/dl/ * golangci-lint * attempt golangci-lint workaround * change version * bump fumpt version * skip strings.title test * go mod tidy * update tests as some aren't private?? * update tests techknowlogick authored at GitHub comitted at
  7. fe9626af Use `go run` for tool dependencies, require go 1.17 (#18874) This ensures the tools only run in the versions we've tested and it also does not polute PATH with those tools so they are truly isolated. This syntax of `go run` requires go 1.17, so the minimum version is set accordingly. Fixes: https://github.com/go-gitea/gitea/issues/18867 Co-authored-by: techknowlogick <techknowlogick@gitea.io> silverwind authored at GitHub comitted at
  8. 6ab4a968 Update golang.org/x/crypto (#19097) * Update golang.org/x/crypto - Update dependency to include fix for CVE. - See https://groups.google.com/g/golang-announce/c/-cp44ypCT5s/m/wmegxkLiAQAJ?utm_medium=email&utm_source=footer * Fix deprecation notice * Remove workaround - Introduced in https://github.com/go-gitea/gitea/pull/17281 - Fixed in x/crypto: - https://github.com/golang/crypto/commit/5d542ad81a58c89581d596f49d0ba5d435481bcf - & https://github.com/golang/crypto/commit/3147a52a75dda54ac3a611ef8978640d85188a2a * Update Kex Algorithms - Use standardized name for curve22519-sha256. https://github.com/golang/crypto/commit/9b076918e3c7e908b2bdea932f272a9979f2488a - Prefer SHA256 version over SHA1 version. https://github.com/golang/crypto/commit/e4b3678e5f38521e67eba223ddd1902ceb3a303c Gusted authored at GitHub comitted at
  9. c88f2e2a Handle email address not exist. (#19089) KN4CK3R authored at GitHub comitted at
  10. 2ba72ced Frontport Changelogs (#19088) * Frontport Changelogs * bump version in docs 6543 authored at GitHub comitted at
  11. 18033f49 Restrict email address validation (#17688) This didn't follow the RFC but it's a subset of that. I think we should narrow the allowed chars at first and discuss more possibility in future PRs. Lunny Xiao authored at GitHub comitted at
  12. 49db87a0 Fix lfs bug (#19072) * Fix lfs bug Lunny Xiao authored at GitHub comitted at
  13. 3ad6cf20 [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  14. 35541f85 Fix documentation and #19065 (#19067) mscherer authored at GitHub comitted at
  15. bc0d2c8a RSS/Atom support for Repos (#19055) * support for repos * refactor * advertise the feeds via meta tags * allow feed suffix and feed header * optimize performance 6543 authored at GitHub comitted at
  16. 780cf76f [skip ci] Updated licenses and gitignores GiteaBot authored at GiteaBot comitted at
  17. 9cca834a Feeds: render markdown to html (#19058) * feeds: render markdown to html Norwin authored at GitHub comitted at
  18. a0c043f5 [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  19. a223bc87 Prevent 500 when there is an error during new auth source post (#19041) Fix #19036 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  20. 886b1de9 Update the webauthn_credential_id_sequence in Postgres (#19048) * Update the webauthn_credential_id_sequence in Postgres There is (yet) another problem with v210 in that Postgres will silently allow preset ID insertions ... but it will not update the sequence value. This PR simply adds a little step to the end of the v210 migration to update the sequence number. Users who have already migrated who find that they cannot insert new webauthn_credentials into the DB can either run: ```bash gitea doctor recreate-table webauthn_credential ``` or ```bash ./gitea doctor --run=check-db-consistency --fix ``` which will fix the bad sequence. Fix #19012 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  21. a0db075f If rendering has failed due to a net.OpError stop rendering (attempt 2) (#19049) Unfortunately #18642 does not work because a `*net.OpError` does not implement the `Is` interface to make `errors.Is` work correctly - thus leading to the irritating conclusion that a `*net.OpError` is not a `*net.OpError`. Here we keep the `errors.Is` because presumably this will be fixed at some point in the golang main source code but also we add a simply type cast to also check. Fix #18629 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  22. ba470a85 use xorm builder for models.getReviewers() (#19033) * xorm builder * dedup code 6543 authored at GitHub comitted at
  23. cc98737c RSS/Atom support for Orgs (#17714) part of #569 6543 authored at GitHub comitted at
  24. 5fdd3042 Fix flag validation (#19046) Regression from #5785 Norwin authored at GitHub comitted at
  25. 75eb6cc9 Improve SyncMirrors logging (#19045) Yet another issue has come up where the logging from SyncMirrors does not provide enough context. This PR adds more context to these logging events. Related #19038 Signed-off-by: Andrew Thornton <art27@cantab.net> zeripath authored at GitHub comitted at
  26. 1314f38b fix pam authorization (#19040) https://huntr.dev/bounties/8d221f92-b2b1-4878-bc31-66ff272e5ceb/ Co-authored-by: ysf <34326+ysf@users.noreply.github.com> zeripath authored at GitHub comitted at
  27. 74432137 [skip ci] Updated translations via Crowdin GiteaBot authored at GiteaBot comitted at
  28. 2448c5ad Upgrading binding package (#19034) Fix #18855 Lunny Xiao authored at GitHub comitted at
  29. c21735b4 Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (#19028) When DISABLE_HTTP_GIT is set we should always show the SSH button wxiaoguang authored at GitHub comitted at
  30. ea46142b Add button for issue deletion (#19032) Co-authored-by: Norwin <noerw@users.noreply.github.com> Co-authored-by: 6543 <6543@obermui.de> Otto Richter (fnetX) authored at GitHub comitted at