| Age | Commit message (Expand) | Author |
|---|
| 2021-05-04 | Only log Error on getLastCommitStatus error to let pull list still be visible... | 6543 |
| 2021-05-03 | Implement delete release attachments and update release attachments' name (#1...•••* Implement delete release attachment
* Add attachments on release edit page
* Fix bug
* Finish del release attachments
* Fix frontend lint
* Fix tests
* Support edit release attachments
* Added tests
* Remove the unnecessary parameter isCreate from UpdateReleaseOrCreatReleaseFromTag
* Rename UpdateReleaseOrCreatReleaseFromTag to UpdateRelease
* Fix middle align
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> | Kyle D |
| 2021-04-26 | fix webhook timeout bug (#15613) (#15621)•••* Also fix the potential problem in httplib | Lunny Xiao |
| 2021-04-16 | Performance improvement for list pull requests (#15447) (#15500)•••Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> | 6543 |
| 2021-04-10 | Always set the merge base used to merge the commit (#15352) (#15385)•••Backport #15352
The issue is that the TestPatch will reset the PR MergeBase - and it is possible for TestPatch to update the MergeBase whilst a merge is ongoing. The ensuing merge will then complete but it doesn't re-set the MergeBase it used to merge the PR.
Fixes the intermittent error in git test.
Signed-off-by: Andrew Thornton art27@cantab.net | zeripath |
| 2021-04-01 | Prevent NPE in CommentMustAsDiff if no hunk header (#15199) (#15200)•••Backport #15199
I do not understand how this can happen or why.
There is an apparent possibility for a comment.Patch to be missing a hunk header
- this should not happen and do not understand how. But it appears to happen on
1.13 at least in some case.
This PR will simply add a new section if the cursection is empty
thus preventing the NPE.
Fix #15198
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de> | zeripath |
| 2021-03-21 | Place wrapper around comment as diff to catch panics (#15085) (#15094)•••Backport #15085
There are a few recurrent issues with comment as diff reporting panics that are resistant to fixing due to the fact that the panic occurs in the template render and is swallowed by the template renderer.
This PR just adds some logging to force the panic to properly logged and re-propagates back up to the template renderer so we can actually detect what the issue is.
Signed-off-by: Andrew Thornton art27@cantab.net | zeripath |
| 2021-03-04 | IsUserAllowedToUpdate ignore igonre if user is nil (#14885) | 6543 |
| 2021-03-03 | Make manual merge autodetection optional and add manual merge as merge method...•••* Make auto check manual merge as a chooseable mod and add manual merge way on ui
as title, Before this pr, we use same way with GH to check manually merge.
It good, but in some special cases, misjudgments can occur. and it's hard
to fix this bug. So I add option to allow repo manager block "auto check manual merge"
function, Then it will have same style like gitlab(allow empty pr). and to compensate for
not being able to detect THE PR merge automatically, I added a manual approach.
Signed-off-by: a1012112796 <1012112796@qq.com>
* make swager
* api support
* ping ci
* fix TestPullCreate_EmptyChangesWithCommits
* Apply suggestions from code review
Co-authored-by: zeripath <art27@cantab.net>
* Apply review suggestions and add test
* Apply suggestions from code review
Co-authored-by: zeripath <art27@cantab.net>
* fix build
* test error message
* make fmt
* Fix indentation issues identified by @silverwind
Co-authored-by: silverwind <me@silverwind.io>
* Fix tests and make manually merged disabled error on API the same
Signed-off-by: Andrew Thornton <art27@cantab.net>
* a small nit
* fix wrong commit id error
* fix bug
* simple test
* fix test
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io> | a1012112796 |
| 2021-03-01 | Migrate to use jsoniter instead of encoding/json (#14841)•••* Migrate to use jsoniter
* fix tests
* update gitea.com/go-chi/binding
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de> | zeripath |
| 2021-03-01 | When Deleting Repository only explicitly close PRs whose base is not this rep...•••When Deleting Repository only explicitly close PRs whose base is not this repository
Fix #14775
Signed-off-by: Andrew Thornton <art27@cantab.net> | zeripath |
| 2021-03-01 | Repository transfer has to be confirmed, if user can not create repo for new ...•••* make repo as "pending transfer" if on transfer start doer has no right to create repo in new destination
* if new pending transfer ocured, create UI & Mail notifications | 6543 |
| 2021-02-28 | Create tag on ui (#13467)•••Support create single tag directly
support create tag with message from create release ui
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net> | a1012112796 |
| 2021-02-27 | Fix a couple of CommentAsPatch issues. (#14804)•••* CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff.
This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer.
Fix #14711
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Handle unquoted comment patch files
When making comment patches unfortunately the patch does not always quote the filename
This makes the diff --git header ambiguous again.
This PR finally adds handling for ambiguity in to parse patch
Fix #14812
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add in testing for no error
There is no way currently for CutDiffAroundLine in this test to cause an
error however, it should still be tested.
Signed-off-by: Andrew Thornton <art27@cantab.net> | zeripath |
| 2021-02-22 | fix a small nit (#14769) | a1012112796 |
| 2021-02-14 | Fix broken spans in diffs (#14678)•••Gitea runs diff on highlighted code fragment for each line in order to provide
code highlight diffs. Unfortunately this diff algorithm is not aware that span tags
and entities are atomic and cannot be split.
The current fixup code makes some attempt to fix these broken tags however, it cannot
handle situations where a tag is split over multiple blocks.
This PR provides a more algorithmic fixup mechanism whereby spans and entities are
completely coalesced into their respective blocks.
This may result in a incompletely reduced diff but - it will definitely prevent the
broken entities and spans that are currently possible.
As a result of this fixup several inconsistencies were discovered in our testcases
and these were also fixed.
Fix #14231
Signed-off-by: Andrew Thornton <art27@cantab.net> | zeripath |
| 2021-02-13 | Whitespace in commits (#14650)•••* Add whitespace to commit view
* Add whitespace to /compare/a...b
* Move repeated whitespaceFlags to gitdiff
* Add whitespace for wiki pages | vnkmpf |
| 2021-02-11 | Added option to disable webhooks (#13176)•••* Added option to disable web hooks
This mod introduces DISABLE_WEB_HOOKS parameter in [security] section
of app.ini (by default set to false). If set to true it disables web
hooks feature. Any existing undelivered web hook tasks will be cancelled.
Any existing web hook definitions will be left untouched in db but
its delivery tasks will be ignored.
Author-Change-Id: IB#1105130
* Webhook spelling fixed
Webhook spelling fixed.
Fixes: 07df6614dc84cdd2e9f39c57577fa1062bd70012
Related: https://github.com/go-gitea/gitea/pull/13176#pullrequestreview-510868421
Author-Change-Id: IB#1105174
* Parameter description fixed
Parameter description fixed.
Fixes: 07df6614dc84cdd2e9f39c57577fa1062bd70012
Related: https://github.com/go-gitea/gitea/pull/13176#pullrequestreview-514086107
Author-Change-Id: IB#1105174 | Paweł Bogusławski |
| 2021-02-11 | Add dismiss review feature (#12674)•••* Add dismiss review feature
refs:
https://github.blog/2016-10-12-dismissing-reviews-on-pull-requests/
https://developer.github.com/v3/pulls/reviews/#dismiss-a-review-for-a-pull-request
* change modal ui and error message
* Add unDismissReview api
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de> | a1012112796 |
| 2021-02-03 | [API] Add pagination to ListBranches (#14524)•••* make PaginateUserSlice generic -> PaginateSlice
* Add pagination to ListBranches
* add skip, limit to Repository.GetBranches()
* Move routers/api/v1/utils/utils PaginateSlice -> modules/util/paginate.go
* repo_module.GetBranches paginate
* fix & rename & more logging
* better description
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: a1012112796 <1012112796@qq.com> | 6543 |
| 2021-01-21 | Enhance Ghost comment mitigation Settings (#14392)•••* refactor models.DeleteComment and delete related reactions too
* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser
* nits
* Use time.Duration as other time settings have
* docs
* Resolve Fixme & fix potential deadlock
* Disabled by Default
* Update Config Value Description
* switch args
* Update models/issue_comment.go
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net> | 6543 |
| 2021-01-17 | label and milestone webhooks on issue/pull creation (#14363) | Jimmy Praet |
| 2021-01-09 | fix mailIssueCommentBatch for pull request (#14252)•••fix #14250
Signed-off-by: a1012112796 <1012112796@qq.com> | a1012112796 |
| 2021-01-06 | Some code improvements (#14266) | Lunny Xiao |
| 2021-01-06 | Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (#14148)•••* Fix wrong type on hooktask to convert typ from char(16) to varchar(16)
* Fix bugs
* Improve code
* Use different trim function for MSSQL
* Fix bug
* Removed wrong changed line
* Removed wrong changed line
* Fix nullable
* Fix lint
* Ignore sqlite on migration
* Fix mssql modify column failure
* Move modifyColumn to migrations.go so that other migrate function could use it | Lunny Xiao |
| 2021-01-02 | Send notifications for mentions in pulls, issues, (code-)comments (#14218)•••Fixes #14187: mention handling extracted from email notification code
Fixes #14013: add notification for mentions in pull request code comments
Fixes #13450: Not receiving any emails with setting "Only Email on Mention" | Jimmy Praet |
| 2021-01-01 | Fix wrong publisher id (#14212)•••Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net> | Lunny Xiao |
| 2020-12-30 | Check for 'main' as potential default branch name (#14193) | Chester Liu |
| 2020-12-26 | Fix escaping issue in diff (#14153)•••Ensure that linecontent is escaped before passing to template.HTML
Signed-off-by: Andrew Thornton <art27@cantab.net> | zeripath |
| 2020-12-25 | migrate from com.* to alternatives (#14103)•••* remove github.com/unknwon/com from models
* dont use "com.ToStr()"
* replace "com.ToStr" with "fmt.Sprint" where its easy to do
* more refactor
* fix test
* just "proxy" Copy func for now
* as per @lunny | 6543 |
| 2020-12-21 | Standardize Co-Authored-By / Reviewed-By strings (#14097)•••* Standardize Co-Authored-By / Reviewed-By strings
* Use lowercase variant
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> | Cirno the Strongest |
| 2020-12-21 | Use the text of pull-request as the squash commit's message (#13071)•••Originally, it was filled by the commit messages of the involved
commits. In this change, we use the headline comment of the pull
request as the commit message when it is a squash merge.
Thanks to @zeripath for suggesting the idea.
Fixes #12365
Co-authored-by: Mura Li <typeless@users.noreply.github.com> | Mura Li |
| 2020-12-20 | Show dropdown with all statuses for commit (#13977)•••* Show dropdown with all statuses for commit
* Use popups
* Remove unnecessary change
* Style popup
* Use divided list
* As per @silverwind
* Refactor GetLastCommitStatus
* Missing dropdown on repo home and commit page
* Fix tests
* Make status icon be a part of a link on PR list
* Fix missing translation call
* Indent fix
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io> | Cirno the Strongest |
| 2020-12-18 | Show status check for merged PRs (#13975)•••* Show status check for merged PRs
* Handle PRs with no commits
* Styling
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: 6543 <6543@obermui.de> | Cirno the Strongest |
| 2020-12-18 | [Refactor] CombinedStatus and CommitStatus related functions & structs (#14026)•••* RM unused struct
* rename (*CommitStatus) loadRepo() -> loadAttributes()
* move ToCommitStatus into its own file
* use CommitStatusState instead of StatusState
* move CombinedStatus convertion into convert package
* let models.GetLatestCommitStatus use repoID direct and accept ListOptions
* update swagger docs
* fix tests
* Fix swagger docs
* rm page
* fix swagger docs!!!
* return json null
* always return json
* rename api.Status to api.CommitStatus
* fix swagger docs
* sec swagger fix | 6543 |
| 2020-12-16 | Send webhook when tag is removed via Web UI (#14015)•••* Send webhook when tag is removed via Web UI
* Stray code | Cirno the Strongest |
| 2020-12-16 | Send push event when tag is created or deleted (#13999)•••Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> | Cirno the Strongest |
| 2020-12-16 | Fix correct diff view for PR review comments in PR view page (#14002)•••Fixes #13683.
The diff snippet that provides context for a code review comment on the pull request timeline page used to be calculated based on the headCommitID. But in 1.13, with PR #13448, this changed to the commitID from the blame for the commented line, which seems to cause these incorrect review comment diff snippets.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> | Jimmy Praet |
| 2020-12-12 | Possible fix the webhook API creation (#13960)•••* Possible fix the webhook API creation
* Fix api create webhook bug | Lunny Xiao |
| 2020-12-12 | Enforce setting HEAD in wiki to master (#13950)•••The default branch in wikis must be master - therefore forcibly set the HEAD
to master.
Fix #13846
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de> | zeripath |
| 2020-12-11 | Ensure that pusher is not nil preventing panic in push (#13945)•••PR #13381 refactored notification actions to call NotifyCreateRef and
NotifyDeleteRef in a slightly different manner. This leads to the pusher
not being set before the call.
This PR ensures that the pusher is updated before the call.
Fix #13940
Signed-off-by: Andrew Thornton <art27@cantab.net> | zeripath |
| 2020-12-11 | Fix bug for webhook and feishu caused by API changed (#13937)•••* Fix bug for webhook
* Fix bug for feishu | Lunny Xiao |
| 2020-12-09 | Fix broken migration on webhook (#13911)•••* Fix broken migration on webhook
* Fix lint
Co-authored-by: John Olheiser <john.olheiser@gmail.com> | Lunny Xiao |
| 2020-12-08 | Move webhook type from int to string (#13664)•••* Move webhook type from int to string
* rename webhook_services
* finish refactor
* Fix merge
* Ignore unnecessary ci
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net> | Lunny Xiao |
| 2020-12-08 | Refactor push update (#13381)•••* Refactor Push update
* Remove the push_test since the function has been removed.
* Use default branch setting instead master | Lunny Xiao |
| 2020-12-08 | Fix Pull Merge when tag with same name as base branch exist (#13882)•••fix dst refspec error in 'Push back to upstream' when base branch have
same name with a tag.
fix #13851
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net> | a1012112796 |
| 2020-12-05 | Fix branch/tag notifications in mirror sync (#13855)•••* Fix branch/tag notifications in mirror sync
* Fix gofmt
Co-authored-by: Gitea <gitea@fake.local>
Co-authored-by: Lauris BH <lauris@nix.lv> | manuelluis |
| 2020-12-03 | Make sure email recipients can see issue (#13820)•••* Initial pass
Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Remove over-op
Signed-off-by: jolheiser <john.olheiser@gmail.com> | John Olheiser |
| 2020-12-02 | Migrations: Use Process Manager to create own Context (#13792) | 6543 |
| 2020-11-28 | Add block on official review requests branch protection (#13705)•••Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: Lauris BH <lauris@nix.lv> | a1012112796 |
