75496b9fChangelog v1.13.4 (#14917)
* Changelog v1.13.4
* nit6543
authored at
GitHub
comitted at
8dad47a9Fix race in LFS ContentStore.Put(...) (#14895) (#14913)
Backport #14895
Continuing on from #14888
The previous implementation has race whereby an incomplete upload or
hash mismatch upload can end up in the ContentStore. This PR moves the
validation into the reader so that if there is a hash error or size
mismatch the reader will return with an error instead of an io.EOF
causing the storage to abort the storage.
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
8e792986Fix a couple of issues with a feeds (#14897) (#14903)
Backport (#14897)
witch fix couple of issues with feeds6543
authored at
GitHub
comitted at
da80e90aFix race in local storage (#14888) (#14901)
LocalStorage should only put completed files in position
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>6543
authored at
GitHub
comitted at
74dc2235When transfering repository and database transaction failed, rollback the renames (#14864) (#14902)
Fix #14821
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Andrew Thornton <art27@cantab.net>6543
authored at
GitHub
comitted at
7d3e1749Signed-off-by: jolheiser <john.olheiser@gmail.com> (#14898) (#14899)
John Olheiser
authored at
GitHub
comitted at
84567004[Docs] Fix how lfs data path is set (#14855) (#14884)
* fix docs: lfs data path
* DEPRECATED | 已废弃
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>6543
authored at
GitHub
comitted at
8a6acbbcIsUserAllowedToUpdate should igonre if user is nil (#14886)
6543
authored at
GitHub
comitted at
98b3d8d5Add changelog for v1.13.3 (#14877)
Add changelog for v1.13.3
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <matti@mdranta.net>Lunny Xiao
authored at
GitHub
comitted at
e663f745Fix paging of file commit logs (#14831) (#14879)
Backport #14831
Unfortunately `git log revision ... --skip=x -- path` skips the number of commits
not the number of commits relating to the path.
This PR changes the function to have a reader that reads and skips the
necessary number of commits by hand instead.
Fix #8716
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <6543@obermui.de>zeripath
authored at
GitHub
comitted at
7e85cba3Print usefull error if SQLite is used in settings but not supported (#14476) (#14874)
* move log output to points where they are relefant
* check explicit of sqlite3 in settings
6543
authored at
GitHub
comitted at
26628aa1Fix display since time round (#14226) (#14873)
Backport #14226
* Fix display since time round
* Fix since time
* Fix tests
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
d9d2e8f1When Deleting Repository only explicitly close PRs whose base is not this repository (#14823) (#14842)
Backport #14823
When Deleting Repository only explicitly close PRs whose base is not this repository
Fix #14775
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
4558eeb2Set HCaptchaSiteKey on Link Account pages (#14834) (#14839)
Backport #14834
When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.
Fix #14766
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
be25afc6Fix a couple of CommentAsPatch issues. (#14804) (#14820)
Backport #14804
* CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff.
This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer.
Fix #14711
* Handle unquoted comment patch files
When making comment patches unfortunately the patch does not always quote the filename
This makes the diff --git header ambiguous again.
This PR finally adds handling for ambiguity in to parse patch
Fix #14812
* Add in testing for no error
There is no way currently for CutDiffAroundLine in this test to cause an
error however, it should still be tested.
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
90bf1e79Disable broken OAuth2 providers at startup (#14802) (#14811)
Backport #14802
Instead of causing a log.Fatal, we should handle broken OAuth2
providers by disabling them.
Fix #8930
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>zeripath
authored at
GitHub
comitted at
77ce0897Re-enable transfer repo back from org to user account (#14807)
* re-enable transfer repo back from org to user account
* add test case6543
authored at
GitHub
comitted at
8f389c5dBuild for only available darwin target (#14771) (#14798)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>6543
authored at
GitHub
comitted at
edef62e6Backport: Repo Transfer permission checks (#14792) (#14794)
* Backport: Repo Transfer permission checks (#14792)
* update tests6543
authored at
GitHub
comitted at
cdff144fFix double alert in oauth2 application edit view (#14764) (#14768)
Signed-off-by: a1012112796 <1012112796@qq.com>a1012112796
authored at
GitHub
comitted at
ad6084a2Fix broken spans in diffs (#14678) (#14683)
Backport #14678
Gitea runs diff on highlighted code fragment for each line in order to
provide code highlight diffs. Unfortunately this diff algorithm is not
aware that span tags and entities are atomic and cannot be split.
The current fixup code makes some attempt to fix these broken tags
however, it cannot handle situations where a tag is split over multiple
blocks.
This PR provides a more algorithmic fixup mechanism whereby spans and
entities are completely coalesced into their respective blocks.
This may result in a incompletely reduced diff but - it will definitely
prevent the broken entities and spans that are currently possible.
As a result of this fixup several inconsistencies were discovered in our
testcases and these were also fixed.
Fix #14231
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>zeripath
authored at
GitHub
comitted at
d3200db0HasPreviousCommit causes recursive load of commits unnecessarily (#14598) (#14649)
This PR improves HasPreviousCommit to prevent the automatic and recursive loading
of previous commits using git merge-base --is-ancestor and git rev-list
Fix #13684
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>zeripath
authored at
GitHub
comitted at
f305cffcPrevent race in PersistableChannelUniqueQueue.Has (#14651) (#14676)
Backport #14651
There is potentially a race with a slow starting internal
queue causing a NPE if Has is checked before the internal
queue has been setup.
This PR adds a lock on the Has() fn.
Fix #14311
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>zeripath
authored at
GitHub
comitted at
c0320065Turn default hash password algorightm back to pbkdf2 from argon2 until we found a better one (#14673) (#14675)
* Turn default hash password algorightm back to pbkdf2 from argon2 until we found a better one
* Add a warning on document
Co-authored-by: zeripath <art27@cantab.net>Lunny Xiao
authored at
GitHub
comitted at
a1b74c55Allow org labels to be set with issue templates (#14593) (#14647)
Backport #14593
Fix #13688
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
101fb0d7Do not assume all 40 char strings are SHA1s (#14624) (#14648)
Backport #14624
GetCommit() assumes that all 40 char strings are SHA1s. This leads to an
error if you try to do a PR on a branch which is 40 characters long.
This PR attempts the SHA first - and if it fails will switch to using rev-parse.
Fix #14470
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
82637c24Accept multiple SSH keys in single LDAP SSHPublicKey attribute (#13989) (#14607)
Backport #13989
Fix #13984
Fix #14566
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
d0174d45Fix bug about ListOptions and stars/watchers pagnation (#14556) (#14573)
* Fix bug about ListOptions and stars/watchers pagnation
* fix unit test
6543
authored at
GitHub
comitted at
da7a525cFix GPG key deletion during account deletion (#14561) (#14569)
Per #14531, deleting a user account will delete the user's GPG keys
from the `gpg_key` table but not from `gpg_key_import`, which causes
an error when creating an account with the same email and attempting
to re-add the same key. This commit deletes all entries from
`gpg_key_import` that match any GPG key IDs belonging to the user.
Co-authored-by: Anton Khimich <anton.khimicha@mail.utoronto.ca>Anton Khimich
authored at
GitHub
comitted at