Commits at cb41f5cae16c5c11cad717c0d19333c2aa4e3b55
cb41f5caUpdate assignees check to include any writing team and change org sidebar (#18680)
Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.
Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.
Fix #18572
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
f7085f71Set max text height to prevent overflow (#18862)
Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button.
Before:

After:

Interestingly, I don't see this bug on Firefox. Kyle D
authored at
GitHub
comitted at
2b9df564Lock gofumpt to v0.3.0 and run it (#18866)
We can't depend on `latest` version of gofumpt because the output will
not be stable across versions. Lock it down to the latest version
released yesterday and run it again.silverwind
authored at
GitHub
comitted at
2b5e0134Fix ldap edit bug (#18856)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>Lunny Xiao
authored at
GitHub
comitted at
c918521dFix behavior or checkbox submission. (#18851)
Gusted
authored at
GitHub
comitted at
704bdf89Don't report signal: killed errors in serviceRPC (#18850)
Fix #18849
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
dc988eaeFix bug for get user by email (#18833)
Co-authored-by: zeripath <art27@cantab.net>Lunny Xiao
authored at
GitHub
comitted at
54dd0fc8migrations: remove dead code in gitea uploader (#18725)
When migrating, g.issues is a map with all issues created during the
migration. If an issue is not found in g.issues when inserting a
comment or a review, it cannot exist in the database and trying to get
it via GetIssueByIndex() will always fail and return an error.
Signed-off-by: singuliere <singuliere@autistici.org>singuliere
authored at
GitHub
comitted at
a387636bShow fullname on issue edits and gpg/ssh signing info (#18827)
Show missing full names when configured to do so
Co-authored-by: zeripath <art27@cantab.net>Wim
authored at
GitHub
comitted at
e039b76aUpdate go-org to 1.6.0 (#18824)
Fix #14074
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
00be0c1bFix login with email for ldap users (#18800)
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.Lunny Xiao
authored at
GitHub
comitted at
83c90359Immediately Hammer if second kill is sent (#18823)
Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2
is sent. We should just immediately hammer if there is a second kill.
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
4b3ebda0Fix panic in EscapeReader (#18820)
There is a potential panic due to a mistaken resetting of the length parameter when
multibyte characters go over a read boundary.
Signed-off-by: Andrew Thornton <art27@cantab.net>zeripath
authored at
GitHub
comitted at
931c2f40Put buttons back in org dashboard (#18817)
Fix #18523Lunny Xiao
authored at
GitHub
comitted at
159c3f48Generate coverage with sqlite. (#18813)
KN4CK3R
authored at
GitHub
comitted at
0cc2675cFix ldap loginname (#18789)
* Use email_address table to check user's email when login with email adress
* Update services/auth/signin.go
* Fix test
* Fix test
* Fix logging in with ldap username != loginname
* Fix if user does not exist yet
* Make more clear this is loginName
* Fix formatting
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>Johan Van de Wauw
authored at
GitHub
comitted at
1ab88da0Replace deprecated String.prototype.substr() with String.prototype.slice() (#18796)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with the slice() method which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>CommanderRoot
authored at
GitHub
comitted at
a7b9d44dFix problem when self-assign notification (#18797)
Lunny Xiao
authored at
GitHub
comitted at
6767798eMove editorconfig-checker to lint-backend and remove JS wrapper (#18793)
* Move editorconfig-checker to lint-backend
It makes more sense there as templates are considered backend code.
* User golang version of the tool
* remove dependencysilverwind
authored at
GitHub
comitted at
18564672Fix redirect when using lowercase reponame (#18775)
* Previously, `GET {username}/{reponame}/raw///file-path` (the middle two slashes are blank to get the default branch) when the repo name has uppercase letters, e.g., https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware, using a lowercase version of the name redirected to the correct URL
* In other words both
* `GET https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware/raw///images/back.png`
* `GET https://try.gitea.io/AbdulrhmnGhanem/ch330_hardware/raw///images/back.png`
were redirecting to ` GET https://try.gitea.io/AbdulrhmnGhanem/CH330_Hardware/raw/branch/master/images/back.png`
This isn't the case after #17551. Specifically because of this [line](https://github.com/zeripath/gitea/blob/cbd5eecd148dfca5fcb1a3da469e491a84f6b32b/modules/context/repo.go#L860).Ghanem
authored at
GitHub
comitted at
3a29a23cAttempt to fix the webauthn migration again - part 3 (#18770)
v208.go is seriously broken as it misses an ID() check. We need to no-op and remigrate all of the u2f keys.
See #18756
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
616146f9Various Mermaid improvements (#18776)
* Various Mermaid improvments
- Render into iframe for improved security
- Use built-in dark theme instead of color inversion
- Remove flexbox attributes, resulting in more consistent size rendering
- Update API usage and update to latest version
* restart ci
* misc tweaks
* remove unneccesary declaration
* make it work without allow-same-origin, add loading=lazy
* remove loading attribute, does not seem to work
* rename variable
* skip roundtrip to DOM for rendering
* don't guess chart height
* update comment to make it clear it's intentional
* tweak
* replace deprecated 'scrolling' property
* remove unused css file
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>silverwind
authored at
GitHub
comitted at