Commits at 59959ab222cee6e679aa373b37c6c4bce348e825
59959ab2Fix login with email panic when email is not exist (#18941)
Lunny Xiao
authored at
GitHub
comitted at
4697735cAdjust error for already locked db and prevent level db lock on malformed connstr (#18923)
This PR adjusts the error returned when there is failure to lock the level db, and
permits a connections to the same leveldb where there is a different connection string.
Reference #18921
Reference #18917
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
548adb94Avoid database lookups for `DescriptionHTML` (#18924)
* Avoid database lookups for `DescriptionHTML`
- Don't Compose meta's for DescriptionHTML, they are only needed in
order to correctly format and show issue's but it's highly unlikely that
a repository description will refer to a local issue.
Using 125 Connections for 5 seconds: on `/explore/repos`(which is the most
noticeable usage by this function's database lookups):
Before:
Statistics Avg Stdev Max
Reqs/sec 569.41 506.05 2715.00
Latency 214.27ms 16.60ms 294.84ms
HTTP codes:
1xx - 0, 2xx - 2974, 3xx - 0, 4xx - 0, 5xx - 0
others - 0
Throughput: 27.17MB/s
After:
Statistics Avg Stdev Max
Reqs/sec 1585.04 789.84 4144.56
Latency 78.89ms 15.89ms 206.94ms
HTTP codes:
1xx - 0, 2xx - 7975, 3xx - 0, 4xx - 0, 5xx - 0
others - 0
Throughput: 73.85MB/s
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>Gusted
authored at
GitHub
comitted at
79c7219bUpdate go-org to v1.6.1 (#18932)
- v1.6.0 has a inconsistency with the proxy and github's tagged version,
updating to v1.6.1 should fix this issue.
- Resolves #18864Gusted
authored at
GitHub
comitted at
f56bba1aFix trace log to show value instead of pointers (#18926)
- Fixes a issue with a trace of repo.Units whereby it would show the pointers.
Before:

After:

Gusted
authored at
GitHub
comitted at
c9da11c6Add announcement steps to release-howto (#18896)
* add announcements steps to release-howto
* Also add homebrew update
Norwin
authored at
GitHub
comitted at
af9da813Fix `<strong>` html in translation (#18929)
Gusted
authored at
GitHub
comitted at
1563a456Fix page and missing return on unadopted repos API (#18848)
* Fix page and missing return on unadopted repos API
Page must be 1 if it's not specified and it should return after sending an internal server error.
* Allow ignore pages
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>qwerty287
authored at
GitHub
comitted at
962725cdAllow adminstrator teams members to see other teams (#18918)
* Allow adminstrator teams to see other teams
- Allow team members with adminstrator access, to view other teams.
- Resolves #18885Gusted
authored at
GitHub
comitted at
aa60cd91Update nginx reverse proxy docs (#18922)
Add additional config lines for the set_header to forward additional information (eg the IP)
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>JonRB
authored at
GitHub
comitted at
bf2867deDon't treat BOM escape sequence as hidden character. (#18909)
* Don't treat BOM escape sequence as hidden character.
- BOM sequence is a common non-harmfull escape sequence, it shouldn't be
shown as hidden character.
- Follows GitHub's behavior.
- Resolves #18837
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Gusted
authored at
GitHub
comitted at
329b9591Remove CodeMirror dependencies (#18911)
EasyMDE already loads all the modes and plugins it needs, so there is no reason for neither the webpack dependency nor the vendored copysilverwind
authored at
GitHub
comitted at
6d55a132Uncapitalize errors (#18915)
- See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>Gusted
authored at
GitHub
comitted at
fa0e2d60Disable service worker by default (#18914)
The service worker causes a lot of issues with JS errors after instance
upgrades while not bringing any real performance gain over regular HTTP
caching.
Disable it by default for this reason. Maybe later we can remove it
completely, as I simply see no benefit in having it.silverwind
authored at
GitHub
comitted at
33e19c80Don't update email for organisation (#18905)
- Fix regression caused by: f1b1472632e36c3bb5df73f184a6efeef47f5d01
- Don't try to insert a email for Organisation(as they don't have one).
- Resolves #18891
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>Gusted
authored at
GitHub
comitted at
fd273b05Correctly link URLs to users/repos with dashes, dots or underscores (#18890)
* Add tests for references with dashes
This commit adds tests for full URLs referencing repos names and user
names containing a dash.
* Extend regex to match URLs to repos/users with dashesAlexander Neumann
authored at
GitHub
comitted at
9d7a431bSet is_private in fixtures. (#18868)
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>KN4CK3R
authored at
GitHub
comitted at
36d31d52Fix team management UI (#18886)
Co-authored-by: 6543 <6543@obermui.de>Lunny Xiao
authored at
GitHub
comitted at
65689f6bUpdate JS dependencies (#18898)
- Updated all JS dependencies minus Vue (update 2 to 3 requires a ton of
work and is probably blocked by dependencies)
- Tested editor, swagger-uisilverwind
authored at
GitHub
comitted at
49cab2b0migrations: add test for importing pull requests in gitea uploader (#18752)
* logs: add the buffer logger to inspect logs during testing
Signed-off-by: Loïc Dachary <loic@dachary.org>
* migrations: add test for importing pull requests in gitea uploader
Signed-off-by: Loïc Dachary <loic@dachary.org>
* for each git.OpenRepositoryCtx, call Close
* Content is expected to return the content of the log
* test for errors before defer
Co-authored-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>singuliere
authored at
GitHub
comitted at
e4ef61eeBeforeSourcePath should point to base commit (#18799)
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>Jimmy Praet
authored at
GitHub
comitted at
f1c6cf7cPrevent Stats Indexer reporting error if repo dir missing (#18870)
Repositories missing their directory should not report an error from the stats
indexer.
Close #18847
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>zeripath
authored at
GitHub
comitted at
f1b14726Fix ldap user sync missed email in email_address table (#18786)
* Fix ldap user sync missed email in email_address table
* Fix testLunny Xiao
authored at
GitHub
comitted at
cb41f5caUpdate assignees check to include any writing team and change org sidebar (#18680)
Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.
Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.
Fix #18572
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
authored at
GitHub
comitted at
f7085f71Set max text height to prevent overflow (#18862)
Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button.
Before:

After:

Interestingly, I don't see this bug on Firefox. Kyle D
authored at
GitHub
comitted at